-
Notifications
You must be signed in to change notification settings - Fork 162
fix(playground): repair local compose config; prettier test_playground.sh output
#4352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
69c5508
fix(playground): repair local compose config; prettier test_playgroun…
igorroncevic 73250d4
update script
igorroncevic 0a533d4
respond to gemini comments
igorroncevic d679bc7
pr feedback
igorroncevic 562f607
fix(playground): remove extra newline in orderbook config
igorroncevic d69af8b
update
igorroncevic e89980b
Merge branch 'main' into fix/playground_startup
igorroncevic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,19 @@ | ||
| eip1271-skip-creation-validation = true | ||
| bind-address = "0.0.0.0:80" | ||
|
|
||
| [order-quoting] | ||
| price-estimation-drivers = [{ name = "baseline", url = "http://driver/baseline" }] | ||
| [shared] | ||
| node-url = "http://chain:8545" | ||
| simulation-node-url = "http://chain:8545" | ||
|
|
||
| [native-price-estimation] | ||
| estimators = [[{ type = "Driver", name = "baseline", url = "http://driver/baseline" }]] | ||
| [shared.tracing] | ||
| collector-endpoint = "http://tempo:4317" | ||
|
|
||
| [database] | ||
| write-url = "%DB_WRITE_URL" | ||
| read-url = "%DB_READ_URL" | ||
|
|
||
| [native-price-estimation] | ||
| estimators = [[{ type = "Driver", name = "baseline", url = "http://driver/baseline" }]] | ||
|
|
||
| [order-quoting] | ||
| price-estimation-drivers = [{ name = "baseline", url = "http://driver/baseline" }] |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jmg-duarte marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this change should be necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing here that it's a required value and it gave me errors without it. Perhaps I'm wrong but it seemed like it just didn't have that value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't hurt being here, but it shouldnt be required, it just wont index ethflow trades
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test_playgroundactually creates an EthFlow order, so this should be here because of it.