Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kube-prometheus-stackHelm chart from 72.6.2 → 83.4.3route.main.enabled: truein the chart's values schema)additionalPrometheusRulesMapfrom list form (silently tolerated by 72.x) to proper map form required by 83.xBreaking changes
grafana_ingress_class_namealert_manager_ingress_class_namecert_manager_cluster_issuer_name(no longer used — Gateway certs are handled by cert-manager watching the Gateway annotation, not per-Ingress)grafana_gateway_parent_ref— object withname,namespace,section_namefields, identifying the Gateway listener the Grafana HTTPRoute attaches toalert_manager_gateway_parent_ref— same shape for AlertmanagerCallers must pass the parent ref matching their cluster's shared Envoy Gateway (e.g.
envoy-tailscale/envoy-gateway-system/https-ctmofor Contiamo EKS).Verified on Contiamo EKS
Applied via Scalr run `run-v0p7o7eb6ovret179` using the commit-pinned module ref (
?ref=082744c). Post-apply checks:additionalPrometheusRulesMapnow renders as `monitoring-stack-kube-prom-blackbox-exporter` and `monitoring-stack-kube-prom-contiamo-rules` — the previously orphaned `kube-prometheus-stack-0` rule (from the list-form render under 72.x) was replaced cleanly by Helm's 3-way mergeRollout story
The first two apply attempts errored with
PrometheusRule monitoring-stack-kube-prom-%!s(int=0)— Go's fmt badverb output when the 83.x template ranprintf "%s" $namewith$namebeing an integer index. Root cause: 72.x acceptedadditionalPrometheusRulesMapas a list, 83.x expects a map. Commit 082744c fixes this.A secondary issue: Scalr's module cache kept reusing the stale 9c35f38 render across fresh runs even after the fix landed on the branch. Workaround was to pin the caller's ref to the commit SHA, which changed the go-getter source string and forced a fresh cache entry. Project-ops will be un-pinned back to a proper version tag (e.g. v0.15.0) once this PR merges and release-please tags a release.
Follow-up
Contiamo/eks-cluster/monitoring.tfin project-ops to reference the new tag instead ofref=082744c🤖 Generated with Claude Code