feature: Populate NetworkSettings.Gateway#4771
Open
must108 wants to merge 1 commit intocontainerd:mainfrom
Open
feature: Populate NetworkSettings.Gateway#4771must108 wants to merge 1 commit intocontainerd:mainfrom
must108 wants to merge 1 commit intocontainerd:mainfrom
Conversation
Contributor
Author
Good suggestion, thanks! I'll add a Tigron e2e test that verifies that |
Contributor
Author
|
@haytok added the test |
AkihiroSuda
reviewed
Mar 6, 2026
AkihiroSuda
requested changes
Mar 6, 2026
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
Please squash the commits
must108
force-pushed
the
inspect-gateway
branch
3 times, most recently
from
fc3cd88 to
c8e2272
Compare
haytok
suggested changes
Mar 6, 2026
Member
haytok
left a comment
haytok
left a comment
There was a problem hiding this comment.
When checking this CI Log, the test TestContainerInspectGateway you have added has failed, so please check your fix.
=== Failing tests ===
TestContainerInspectGateway
must108
force-pushed
the
inspect-gateway
branch
3 times, most recently
from
2b0bd48 to
ec66442
Compare
Contributor
Author
haytok
suggested changes
Mar 15, 2026
Member
haytok
left a comment
haytok
left a comment
There was a problem hiding this comment.
Before requesting a review, please make sure that the tests for the changes you’ve made have passed 🙏
| testCase.Run(t) | ||
| } | ||
|
|
||
| func TestContainerInspectGateway(t *testing.T) { |
Member
There was a problem hiding this comment.
Have you already checked CI failures related to this fix?
Signed-off-by: Mustaeen Ahmed <contact@mustaeen.dev> add test TestContainerInspectGateway Signed-off-by: Mustaeen Ahmed <contact@mustaeen.dev> Fix test issues Signed-off-by: Mustaeen Ahmed <contact@mustaeen.dev> Remove container.test Signed-off-by: Mustaeen Ahmed <contact@mustaeen.dev> Resolve review and tests Signed-off-by: Mustaeen Ahmed <contact@mustaeen.dev> feature: populate NetworkSettings.Gateway and add e2e coverage Signed-off-by: Mustaeen Ahmed <contact@mustaeen.dev> Resolve test issues Signed-off-by: Mustaeen Ahmed <contact@mustaeen.dev> feature: populate NetworkSettings.Gateway and add e2e coverage Signed-off-by: Mustaeen Ahmed <contact@mustaeen.dev> drop unrelated hostsstore changes Signed-off-by: Mustaeen Ahmed <contact@mustaeen.dev> Change testing feature: populate NetworkSettings.Gateway and add e2e coverage Resolve breaking tests Add gateway to docker inspect output Signed-off-by: Mustaeen Ahmed <contact@mustaeen.dev> Resolve test failures Signed-off-by: Mustaeen Ahmed <contact@mustaeen.dev>
must108
force-pushed
the
inspect-gateway
branch
from
ec66442 to
8f8e6fe
Compare
Member
https://github.com/containerd/nerdctl/actions/runs/23119762664/job/67191519034?pr=4771 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #415
Issue
NetworkSettings.Gatewayis expected to be present in inspect output.nerdctldid not expose this prior to this change, even when a default gateway existed.Changes
This pull request adds a feature that allows for
NetworkSettings.Gatewayto be populated innerdctl inspectoutput.How it works:
Collects default IPv4 gateway from the container network namespace during netns inspection
Stores the gateway in inspect network data
Propagates the value to
DefaultNetworkSettings.GatewayUnit tests have also been adjusted to reflect this change.
Testing
Notes