Remove ereg validation of IP address. #263
Open
mreiden wants to merge 6 commits intoconsolibyte:masterfrom
Open
Remove ereg validation of IP address. #263mreiden wants to merge 6 commits intoconsolibyte:masterfrom
mreiden wants to merge 6 commits intoconsolibyte:masterfrom
Conversation
…ing ereg IPv4 validation with FILTER_VALIDATE_IP. Remove commented out (since before initial github commit Jan 19, 2012) ereg date checking code replaced by using QuickBooks_QBXML_Object->setDateType. Solves consolibyte#89.
…Server/Handlers.php" (does not exist) to "QuickBooks/WebConnector/Handlers.php" in handler_options comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes using WebConnector with PHP7+ with allow_remote_addr/deny_remote_addr handler_options. The ereg just validates the string is IPv4, so use filter_var with FILTER_VALIDATE_IP. Also remove commented out ereg date checking code (This was replaced by using QuickBooks_QBXML_Object->setDateType years ago).
Solves Issue #89.