Inherit workspace ruff config for connectrpc-otel#183
Merged
anuraaga merged 1 commit intoconnectrpc:mainfrom Mar 23, 2026
Merged
Inherit workspace ruff config for connectrpc-otel#183anuraaga merged 1 commit intoconnectrpc:mainfrom
anuraaga merged 1 commit intoconnectrpc:mainfrom
Conversation
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
anuraaga
commented
Mar 23, 2026
| from opentelemetry.metrics import MeterProvider | ||
| from opentelemetry.trace import TracerProvider | ||
|
|
||
| from connectrpc.interceptor import Interceptor, InterceptorSync |
Collaborator
Author
There was a problem hiding this comment.
@stefanvanburen I think you may have set up imports like this as first-party elsewhere. Personally, I find the default of treating workspace members as third-party ok since I don't see particularly better readability otherwise, and then we get it with no manual config
Member
There was a problem hiding this comment.
yeah, I really don't mind either way, all a matter of taste/consistency. works for me.
stefanvanburen
approved these changes
Mar 23, 2026
| from opentelemetry.metrics import MeterProvider | ||
| from opentelemetry.trace import TracerProvider | ||
|
|
||
| from connectrpc.interceptor import Interceptor, InterceptorSync |
Member
There was a problem hiding this comment.
yeah, I really don't mind either way, all a matter of taste/consistency. works for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always forget it