Skip to content

chore: bump codeflash-java-runtime to 1.0.1#1960

Merged
misrasaurabh1 merged 7 commits intomainfrom
chore/bump-java-runtime-1.0.1
Apr 2, 2026
Merged

chore: bump codeflash-java-runtime to 1.0.1#1960
misrasaurabh1 merged 7 commits intomainfrom
chore/bump-java-runtime-1.0.1

Conversation

@mashraf-222
Copy link
Copy Markdown
Contributor

Summary

  • Bumps codeflash-java-runtime version from 1.0.0 to 1.0.1 in pom.xml
  • JAR 1.0.1 has been published to Maven Central

🤖 Generated with Claude Code

Published 1.0.1 to Maven Central with latest runtime changes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@claude
Copy link
Copy Markdown
Contributor

claude bot commented Apr 1, 2026

Claude finished @mashraf-222's task in 2m 32s —— View job


PR Review Summary

  • Triage PR scope — SMALL (version bump across 8 files, ~50 lines changed)
  • Lint and type check — prek passed, no issues
  • Resolve stale threads — none found
  • Code review
  • Duplicate detection

Prek Checks

All clean — ruff check and format passed.

Code Review

No binary JAR committed
The old codeflash-runtime-1.0.0.jar is deleted and no new JAR is committed. Good — the JAR is fetched from Maven Central at runtime, as intended.

Logic change in add_codeflash_dependency — worth noting
The behavior changed from "only replace <scope>system</scope> dependencies" to "replace any existing codeflash-runtime dependency". This is intentional for version upgrade support (users running again after 1.0.0 was installed will get updated to 1.0.1), but it means the function now silently overwrites any pinned version a user may have set. This seems acceptable for a managed dependency, just flagging it as a behavioral change beyond a pure version bump.

Hardcoded JAR name in two places despite a centralized constant existing — minor
build_tools.py defines CODEFLASH_RUNTIME_VERSION = "1.0.1" and CODEFLASH_RUNTIME_JAR_NAME, but two files still hardcode the version:

  • gradle_strategy.py:435: dest_jar = libs_dir / "codeflash-runtime-1.0.1.jar"gradle_strategy.py already imports from build_tools, so this should use CODEFLASH_RUNTIME_JAR_NAME. Fix this →

  • maven_strategy.py:574-575: The _M2_JAR class attribute hardcodes "1.0.1" and "codeflash-runtime-1.0.1.jar" — yet CODEFLASH_RUNTIME_VERSION and CODEFLASH_RUNTIME_JAR_NAME are already imported at the top of the same file. Should use those constants. Fix this →

build_tool_strategy.py:24 has _RUNTIME_JAR_NAME as a separate hardcoded constant — this is trickier since build_tools is only imported under TYPE_CHECKING there; worth a follow-up but not blocking.

Duplicate Detection

No duplicates detected. The version constant is intentionally split across build_tools.py (centralized) and two other files (hardcoded) — not a duplication of logic, but a consolidation opportunity noted above.


Last updated: 2026-04-01T23:17Z

@aseembits93 aseembits93 enabled auto-merge April 1, 2026 22:35
Update CODEFLASH_RUNTIME_VERSION, hardcoded JAR names, m2 cache path,
and bundled JAR so users resolve 1.0.1 from Maven Central.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are committing a jar file @mashraf-222

mashraf-222 and others added 2 commits April 1, 2026 22:52
JAR is resolved from Maven Central at runtime. The bundled copy
added 16MB of bloat and got stale between releases.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The reviewer asked to remove the bundled JAR file, not the code
that looks for it. The fallback paths are still valid if a JAR
is placed there manually or by future tooling.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
misrasaurabh1
misrasaurabh1 previously approved these changes Apr 1, 2026
…ERSION

Three places in maven_strategy.py had the version hardcoded instead of
using the constant: the dependency snippet, the install-file command,
and the system-scope replacement. This caused CI failures because the
pom.xml dependency pointed to 1.0.0 while ~/.m2 had 1.0.1.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mashraf-222 and others added 2 commits April 1, 2026 23:13
The tracer e2e fixture and code_to_optimize/java pom.xml files had
hardcoded 1.0.0 dependency versions, causing compilation failures
in CI when only 1.0.1 is installed to ~/.m2.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Previously, if codeflash-runtime was already in a user's pom.xml
(e.g. from a prior run with 1.0.0), the dependency was left as-is.
After a CLI upgrade expecting 1.0.1, Maven would fail to resolve
the old version. Now the dependency is always updated to match
CODEFLASH_RUNTIME_VERSION, handling both version bumps and the
legacy system-scope to test-scope migration in one pass.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@misrasaurabh1 misrasaurabh1 disabled auto-merge April 2, 2026 00:29
@misrasaurabh1 misrasaurabh1 merged commit ed6afc0 into main Apr 2, 2026
35 of 38 checks passed
@misrasaurabh1 misrasaurabh1 deleted the chore/bump-java-runtime-1.0.1 branch April 2, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants