Skip to content

fix: add merged to finished state#770

Merged
thomasrockhu-codecov merged 2 commits intomainfrom
th/consider-merged-finished
Mar 16, 2026
Merged

fix: add merged to finished state#770
thomasrockhu-codecov merged 2 commits intomainfrom
th/consider-merged-finished

Conversation

@thomasrockhu-codecov
Copy link
Contributor

@thomasrockhu-codecov thomasrockhu-codecov commented Mar 16, 2026

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Low Risk
Low risk, small change limited to an idempotency guard in the upload finisher. Main risk is incorrectly skipping work if merged is reached before all required finisher steps in some edge case.

Overview
Updates UploadFinisherTask's idempotency check to consider the merged upload state as a final/terminal state (alongside processed and error). This allows repeated/duplicated finisher invocations to short-circuit when uploads have already been merged, reducing redundant processing.

Written by Cursor Bugbot for commit 5928de2. This will update automatically on new commits. Configure here.

@sentry
Copy link

sentry bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.27%. Comparing base (138b687) to head (5928de2).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #770   +/-   ##
=======================================
  Coverage   92.27%   92.27%           
=======================================
  Files        1305     1305           
  Lines       47938    47938           
  Branches     1628     1628           
=======================================
  Hits        44233    44233           
  Misses       3396     3396           
  Partials      309      309           
Flag Coverage Δ
workerintegration 58.56% <ø> (ø)
workerunit 90.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@thomasrockhu-codecov thomasrockhu-codecov added this pull request to the merge queue Mar 16, 2026
Merged via the queue into main with commit d5d05f9 Mar 16, 2026
39 checks passed
@thomasrockhu-codecov thomasrockhu-codecov deleted the th/consider-merged-finished branch March 16, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants