fix: add merged to finished state#770
Merged
thomasrockhu-codecov merged 2 commits intomainfrom Mar 16, 2026
Merged
Conversation
drazisil-codecov
approved these changes
Mar 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #770 +/- ##
=======================================
Coverage 92.27% 92.27%
=======================================
Files 1305 1305
Lines 47938 47938
Branches 1628 1628
=======================================
Hits 44233 44233
Misses 3396 3396
Partials 309 309
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Note
Low Risk
Low risk, small change limited to an idempotency guard in the upload finisher. Main risk is incorrectly skipping work if
mergedis reached before all required finisher steps in some edge case.Overview
Updates
UploadFinisherTask's idempotency check to consider themergedupload state as a final/terminal state (alongsideprocessedanderror). This allows repeated/duplicated finisher invocations to short-circuit when uploads have already been merged, reducing redundant processing.Written by Cursor Bugbot for commit 5928de2. This will update automatically on new commits. Configure here.