Skip to content

perf: batch fetch flag comparison data#733

Open
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/batch-flag-comparison
Open

perf: batch fetch flag comparison data#733
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/batch-flag-comparison

Conversation

@sentry
Copy link
Contributor

@sentry sentry bot commented Feb 28, 2026

Fixes WORKER-PFZ. The issue was that: Flag comparison loop executes two database queries per flag, causing an N+1 query problem.

  • Previously, RepositoryFlag and CompareFlag records were fetched individually within a loop, leading to N+1 query issues.
  • This change refactors the _store_flag_comparison_data method to batch fetch RepositoryFlag and CompareFlag records.
  • RepositoryFlag records are now fetched in a single query for all relevant flag names.
  • CompareFlag records are now fetched in a single query for all relevant repository flag IDs.
  • This significantly reduces the number of database queries and improves performance.

This fix was generated by Seer in Sentry, triggered by Tom Hu. 👁️ Run ID: 10940055

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@sentry
Copy link
Contributor Author

sentry bot commented Feb 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.24%. Comparing base (18696c1) to head (d36d2a3).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #733   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files        1302     1302           
  Lines       47901    47907    +6     
  Branches     1628     1628           
=======================================
+ Hits        44188    44194    +6     
  Misses       3404     3404           
  Partials      309      309           
Flag Coverage Δ
workerintegration 58.58% <0.00%> (-0.03%) ⬇️
workerunit 90.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants