fix(worker): fallback to latest known default-branch parent when provider ancestry isn't in DB#724
Open
nikosatwork wants to merge 1 commit intocodecov:mainfrom
Open
Conversation
…ider ancestry isn't in DB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a default-branch fallback in worker parent selection when provider-reported ancestry cannot be matched to known commits in DB.
If the commit is on the repository default branch and normal ancestry lookup fails, worker now selects the latest earlier known commit on that same default branch.
Why
In some cases provider ancestry is unavailable or not yet represented in DB, which can leave parent selection unresolved even when there is clear recent default-branch history already known to Codecov.
This fallback reduces “missing parent/base” outcomes for default-branch commits while preserving existing behavior for non-default branches.
What changed
fetch_appropriate_parent_for_commit, after existing parent/ancestor strategies fail, add a fallback:Scope
Validation
Related
Closes codecov/feedback#861
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.