feat: Add command for adding schedules to subscriptions by calvin-codecov · Pull Request #707 · codecov/umbrella

calvin-codecov · 2026-02-10T22:56:07Z

Adds general command for the team to run to bulk add subscription schedules for Owners. It will procure the matching owners based on the arguments and process each.

Takes these as user provided arguments:

end date
target plan (if it is switching plans)
dry-run
renew-date-gte
renew-date-lte
owner ids array allowlist
current plan that we want to filter owners by
owner ids array exclude list
limit for # owners to run for
ownerid cursor for batching

Handles multiple scenarios for each owner

if this subscription already has had this applied and the dates match up, skip
if the dates don't match up, update the date
if this subscription has a unrelated schedule, add to the schelude
create a subscription schedule if it doesn't have a schedule already

The command will return a summary of what happened and the owner id for the last acted upon owner.

PR also adds to the modify_subscription webhook handler logic to reapply the schedule if the subscription encounters an upgrade after the command has been run as upgrades will release schedules.

Note

Medium Risk
Touches Stripe billing/scheduling flows and adds a bulk command that can modify many subscriptions; correctness around schedule metadata/end dates and error recovery is important but changes are localized and covered by tests.

Overview
Adds a new apply_subscription_schedules Django management command to bulk create/update Stripe subscription schedules that transition (optionally) to a target plan and then cancel at a specified end date, with filtering, batching, idempotent skip behavior, and --dry-run support.

Introduces shared schedule task_signature constants and a reusable _create_end_date_schedule helper, and updates StripeService.modify_subscription so upgrades that release schedules will detect prior cancellation schedules and recreate/restore the end-date schedule (including recovery when the upgrade Stripe call fails). Includes comprehensive unit tests for the command and the new upgrade/schedule-recreation behaviors.

^{Written by Cursor Bugbot for commit a526ac1. This will update automatically on new commits. Configure here.}

apps/codecov-api/billing/management/commands/apply_subscription_schedules.py

apps/codecov-api/services/billing.py

apps/codecov-api/billing/management/commands/apply_subscription_schedules.py

apps/codecov-api/services/billing.py

apps/codecov-api/billing/management/commands/apply_subscription_schedules.py

apps/codecov-api/services/billing.py

calvin-codecov · 2026-02-11T18:51:28Z

apps/codecov-api/services/billing.py

-        #   If the user is not in a schedule, update immediately
-        #   If the user is in a schedule, update the existing schedule


This comment was actually already no longer correct and had not been updated. This handler has been releasing the existing schedule for a long time.

apps/codecov-api/billing/management/commands/apply_subscription_schedules.py

apps/codecov-api/services/tests/test_billing.py

…ures

sentry · 2026-02-12T18:00:43Z

Codecov Report

❌ Patch coverage is 78.78788% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.20%. Comparing base (cf5ee52) to head (a526ac1).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...anagement/commands/apply_subscription_schedules.py	77.56%	35 Missing ⚠️
apps/codecov-api/services/billing.py	82.50%	7 Missing ⚠️

❌ Your patch check has failed because the patch coverage (78.78%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #707      +/-   ##
==========================================
- Coverage   92.25%   92.20%   -0.06%     
==========================================
  Files        1302     1303       +1     
  Lines       47854    48050     +196     
  Branches     1628     1628              
==========================================
+ Hits        44149    44303     +154     
- Misses       3396     3438      +42     
  Partials      309      309

Flag	Coverage Δ
apiunit	`96.16% <78.78%> (-0.20%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

codecov-notifications · 2026-02-12T18:00:53Z

Codecov Report

❌ Patch coverage is 78.78788% with 42 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...anagement/commands/apply_subscription_schedules.py	77.56%	35 Missing ⚠️
apps/codecov-api/services/billing.py	82.50%	7 Missing ⚠️

❌ Your patch check has failed because the patch coverage (78.78%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

apps/codecov-api/services/billing.py

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

cursor · 2026-02-13T09:42:00Z

apps/codecov-api/services/billing.py

+                    log.info(
+                        f"Restored end-date schedule for owner {owner.ownerid} after upgrade failure"
+                    )
+                raise


Error recovery can mask original StripeError exception

Medium Severity

The schedule recovery code inside the except stripe.StripeError block (lines 486–502) calls stripe.Subscription.retrieve and _create_end_date_schedule (which itself makes two Stripe API calls) without its own try/except. If any of those calls fail, the new exception replaces the original upgrade failure, and the raise on line 503 is never reached. This masks the root cause of the upgrade failure. The post-success path at lines 512–533 correctly wraps _create_end_date_schedule in try/except to handle exactly this scenario — the error recovery path needs the same treatment.

Additional Locations (1)

apps/codecov-api/services/billing.py#L511-L533

thomasrockhu-codecov

Probably need Ajay to really review the logic

thomasrockhu-codecov · 2026-02-18T18:55:27Z

apps/codecov-api/services/billing.py

+    If subscription is not provided, it is retrieved from Stripe.
+    """
+    if subscription is None:
+        subscription = stripe.Subscription.retrieve(owner.stripe_subscription_id)


what happens if this fails?

thomasrockhu-codecov · 2026-02-18T18:56:37Z

apps/codecov-api/services/billing.py

+    if phase2_plan_id is None:
+        phase2_plan_id = phase1_plan_id
+    if phase2_quantity is None:
+        phase2_quantity = phase1_quantity


nit: can this be done before subscription call? or change the argument ordering. helps to read the code more smoothly

thomasrockhu-codecov · 2026-02-18T18:57:20Z

apps/codecov-api/services/billing.py

+        "task_signature": task_signature,
+        "end_date": end_date.strftime("%Y-%m-%d"),
+        "script_version": "1.0",


nit: alphabetize

thomasrockhu-codecov · 2026-02-18T19:09:22Z

apps/codecov-api/services/billing.py

        # An increase in seats and/or plan implies the user is upgrading, hence 'is_upgrading' is a consequence
        # of proration_behavior providing an invoice, in this case, != "none"
        # TODO: change this to "self._is_upgrading_seats(owner, desired_plan) or self._is_extending_term(owner, desired_plan)"
        is_upgrading = (


does this also handle downgrading and the comment is off?

thomasrockhu-codecov · 2026-02-18T19:10:45Z

apps/codecov-api/services/billing.py

+                    # payment_behavior="pending_if_incomplete",
+                )
+            except stripe.StripeError:
+                # Upgrade payment failed but we already released the schedule so add back an end-date schedule so the user doesn't lose it


does the schedule release have to happen after the above step then? would that prevent the need to rollback?

thomasrockhu-codecov · 2026-02-18T19:13:06Z

apps/codecov-api/billing/management/commands/apply_subscription_schedules.py

+                self.style.WARNING("DRY RUN MODE - No changes will be made to Stripe")
+            )
+
+        # Build queryset of owners to process


dat comment

thomasrockhu-codecov · 2026-02-18T19:13:50Z

apps/codecov-api/billing/management/commands/apply_subscription_schedules.py

+        owners = list(owners[:limit])
+
+        # Output summary
+        self.stdout.write(f"Total matching owners: {total_matching}")


we probably want to write to a file here as well

sentry bot reviewed Feb 10, 2026

View reviewed changes

cursor bot reviewed Feb 10, 2026

View reviewed changes

calvin-codecov force-pushed the cy/stripe_yearly_sub_sched_action branch from a1aafd4 to 7e2f900 Compare February 10, 2026 23:20

calvin-codecov changed the title ~~feat: Add command for adding end dates to annual plans~~ feat: Add command for adding schedules to subscriptions Feb 10, 2026

sentry bot reviewed Feb 10, 2026

View reviewed changes

apps/codecov-api/billing/management/commands/apply_subscription_schedules.py Outdated Show resolved Hide resolved

cursor bot reviewed Feb 11, 2026

View reviewed changes

sentry bot reviewed Feb 11, 2026

View reviewed changes

apps/codecov-api/services/billing.py Show resolved Hide resolved

cursor bot reviewed Feb 11, 2026

View reviewed changes

apps/codecov-api/billing/management/commands/apply_subscription_schedules.py Outdated Show resolved Hide resolved

apps/codecov-api/services/billing.py Outdated Show resolved Hide resolved

apps/codecov-api/services/billing.py Outdated Show resolved Hide resolved

calvin-codecov commented Feb 11, 2026

View reviewed changes

cursor bot reviewed Feb 11, 2026

View reviewed changes

apps/codecov-api/billing/management/commands/apply_subscription_schedules.py Show resolved Hide resolved

apps/codecov-api/services/tests/test_billing.py Outdated Show resolved Hide resolved

calvin-codecov added 5 commits February 12, 2026 09:52

feat: Add command for adding schedules to subscriptions

5f0d863

fix: Address bot comments

ec88211

ref: Change stripe modify call signature for consistency

dd8c188

ref: Consolidate schedule creation and recreate end schedule for fail…

21ad3ec

…ures

test: Modify billing.py tests

f36f356

calvin-codecov force-pushed the cy/stripe_yearly_sub_sched_action branch from 938002c to f36f356 Compare February 12, 2026 17:52

cursor bot reviewed Feb 12, 2026

View reviewed changes

apps/codecov-api/services/billing.py Outdated Show resolved Hide resolved

apps/codecov-api/services/billing.py Outdated Show resolved Hide resolved

fix: Move create schedule to billing and handle error situation

a526ac1

cursor bot reviewed Feb 13, 2026

View reviewed changes

thomasrockhu-codecov requested changes Feb 18, 2026

View reviewed changes

		# If the user is not in a schedule, update immediately
		# If the user is in a schedule, update the existing schedule

Conversation

calvin-codecov commented Feb 10, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sentry bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov-notifications bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Feb 13, 2026

Choose a reason for hiding this comment

Error recovery can mask original StripeError exception

Uh oh!

thomasrockhu-codecov left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

calvin-codecov commented Feb 10, 2026 •

edited by cursor bot

Loading

sentry bot commented Feb 12, 2026 •

edited

Loading

codecov-notifications bot commented Feb 12, 2026 •

edited

Loading