Skip to content

integration: Adds Docker container usage for minions#417

Merged
petrutlucian94 merged 2 commits intocloudbase:masterfrom
claudiubelu:integration-tests-docker
Apr 29, 2026
Merged

integration: Adds Docker container usage for minions#417
petrutlucian94 merged 2 commits intocloudbase:masterfrom
claudiubelu:integration-tests-docker

Conversation

@claudiubelu
Copy link
Copy Markdown
Member

Adds docker-related utils. Updates the test provider to create docker container minions instead of using 127.0.0.1 as a minion.

Adds data-minion Dockerfile. The container image will have openssh-server (Coriolis will SSH into it) and systemd installed in it
(Coriolis will set up systemd units for the replicator and the writer)

The integration tests now require a container image for minions to run.

@claudiubelu claudiubelu changed the title Integration tests docker integration: Adds Docker container usage for minions Apr 28, 2026
@claudiubelu claudiubelu force-pushed the integration-tests-docker branch 5 times, most recently from 3946171 to 2d47ce8 Compare April 28, 2026 11:33
Copy link
Copy Markdown
Member

@petrutlucian94 petrutlucian94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

Comment thread coriolis/tests/integration/base.py Outdated
Comment thread coriolis/tests/integration/base.py Outdated
@claudiubelu claudiubelu force-pushed the integration-tests-docker branch from 2d47ce8 to 555315e Compare April 29, 2026 09:12
SSH clients are being created in multiple places. We should add an util
function for it.
Adds docker-related utils. Updates the test provider to create docker
container minions instead of using 127.0.0.1 as a minion.

Adds data-minion Dockerfile. The container image will have
openssh-server (Coriolis will SSH into it) and systemd installed in it
(Coriolis will set up systemd units for the replicator and the writer)

The integration tests now require a container image for minions to run.
@claudiubelu claudiubelu force-pushed the integration-tests-docker branch from 555315e to 1e4ff74 Compare April 29, 2026 09:43
@petrutlucian94 petrutlucian94 merged commit 640780e into cloudbase:master Apr 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants