BytesCursor abstraction in FuseDevWriter#221
Open
stepancheg wants to merge 2 commits intocloud-hypervisor:masterfrom
Open
BytesCursor abstraction in FuseDevWriter#221stepancheg wants to merge 2 commits intocloud-hypervisor:masterfrom
stepancheg wants to merge 2 commits intocloud-hypervisor:masterfrom
Conversation
Contributor
|
somehow CI is not running. Let me close and reopen to trigger it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FuseDevWriter.buffield isManuallyDrop<Vec<u8>>, but actually it is a pair of&mut [u8]space and position.Express this logic more explicitly with
Because:
&mutpointers). It may be not an issue, but with this change is much more clear