fuse_t_session: Correctly handle EOF#158
Open
griff wants to merge 1 commit intocloud-hypervisor:masterfrom
Open
fuse_t_session: Correctly handle EOF#158griff wants to merge 1 commit intocloud-hypervisor:masterfrom
griff wants to merge 1 commit intocloud-hypervisor:masterfrom
Conversation
griff
requested review from
bergwolf,
eryugey,
imeoer,
jiangliu and
liubogithub
as code owners
jiangliu
approved these changes
Oct 10, 2023
Contributor
|
lgtm, but please |
Contributor
Author
Done |
Contributor
|
Still failing. You can run |
The fuse-t session uses a socket pair for communication but wasn't correctly handling EOF and so when trying to gracefully unmount it would just hang. This change simply deals with EOF in the channel and returns None when it occurs during header read and an error otherwise. Signed-off-by: Brian Olsen <brian@maven-group.org>
Contributor
Author
|
I have now run the check locally and fixed the issues found there. |
Contributor
I tried it locally and got the same results. Please help to fix it. You can reproduce by running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fuse-t session uses a socket pair for communication but wasn't correctly handling EOF and so when trying to gracefully unmount it would just hang. This change simply deals with EOF in the channel and returns None when it occurs during header read and an error otherwise.