Skip to content

Remove Easy Image references from documentation.#20041

Open
mmotyczynska wants to merge 2 commits intostablefrom
ck/9476-remove-references-to-easy-image
Open

Remove Easy Image references from documentation.#20041
mmotyczynska wants to merge 2 commits intostablefrom
ck/9476-remove-references-to-easy-image

Conversation

@mmotyczynska
Copy link
Copy Markdown
Contributor

@mmotyczynska mmotyczynska commented Apr 6, 2026

🚀 Summary

⚠️ To be merged with https://github.com/ckeditor/ckeditor5-commercial/pull/9658


📌 Related issues


💡 Additional information

Optional: Notes on decisions, edge cases, or anything helpful for reviewers.


🧾 Checklists

Use the following checklists to ensure important areas were not overlooked.
This does not apply to feature-branch merges.
If an item is not relevant to this type of change, simply leave it unchecked.

Author checklist

  • Is the changelog entry intentionally omitted?
  • Is the change backward-compatible?
  • Have you considered the impact on different editor setups and core interactions? (e.g., classic/inline/multi-root/many editors, typing, selection, paste, tables, lists, images, collaboration, pagination)
  • Has the change been manually verified in the relevant setups?
  • Does this change affect any of the above?
  • Is performance impacted?
  • Is accessibility affected?
  • Have tests been added that fail without this change (against regression)?
  • Have the API documentation, guides, feature digest, and related feature sections been updated where needed?
  • Have metadata files (ckeditor5-metadata.json) been updated if needed?
  • Are there any changes the team should be informed about (e.g. architectural, difficult to revert in future versions or having impact on other features)?
  • Were these changes documented (in Logbook)?

Reviewer checklist

  • PR description explains the changes and the chosen approach (especially when performance, API, or UX is affected).
  • The changelog entry is clear, user‑ or integrator-facing, and it describes any breaking changes.
  • All new external dependencies have been approved and mentioned in LICENSE.md (if any).
  • All human-readable, translateable strings in this PR been introduced using t() (if any).
  • I manually verified the change (e.g., in manual tests or documentation).
  • The target branch is correct.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

Bugbot Autofix prepared fixes for both issues found in the latest run.

  • ✅ Fixed: Removing EasyImage breaks image upload in bootstrap example
    • Added CloudServicesUploadAdapter import and plugin registration so ImageUpload has a Cloud Services upload adapter again.
  • ✅ Fixed: Removing EasyImage leaves no upload adapter in snippet
    • Added CloudServicesUploadAdapter to the bottom-toolbar snippet imports and plugin list to restore file upload handling.

Create PR

Or push these changes by commenting:

@cursor push 0257c62adb
Preview (0257c62adb)
diff --git a/docs/_snippets/examples/bottom-toolbar-editor.js b/docs/_snippets/examples/bottom-toolbar-editor.js
--- a/docs/_snippets/examples/bottom-toolbar-editor.js
+++ b/docs/_snippets/examples/bottom-toolbar-editor.js
@@ -8,7 +8,7 @@
 	ToolbarView, createDropdown, Essentials, Heading, HorizontalLine, Image,
 	ImageInsert, ImageCaption, ImageStyle, ImageToolbar, ImageUpload, ImageResize, Link,
 	MediaEmbed, Paragraph, RemoveFormat, Bold, Italic, Strikethrough, Superscript, Subscript,
-	Underline, Table, TableToolbar
+	Underline, Table, TableToolbar, CloudServicesUploadAdapter
 } from 'ckeditor5';
 import {
 	CS_CONFIG,
@@ -119,6 +119,7 @@
 			ImageStyle,
 			ImageToolbar,
 			ImageUpload,
+			CloudServicesUploadAdapter,
 			Indent,
 			Italic,
 			Link,

diff --git a/packages/ckeditor5-ui/docs/_snippets/examples/bootstrap-ui.js b/packages/ckeditor5-ui/docs/_snippets/examples/bootstrap-ui.js
--- a/packages/ckeditor5-ui/docs/_snippets/examples/bootstrap-ui.js
+++ b/packages/ckeditor5-ui/docs/_snippets/examples/bootstrap-ui.js
@@ -11,6 +11,7 @@
 	UnderlineEditing,
 	Clipboard,
 	CloudServices,
+	CloudServicesUploadAdapter,
 	Editor,
 	ElementApiMixin,
 	attachToForm,
@@ -280,7 +281,7 @@
 BootstrapEditor
 	.create( $( '#editor' ).get( 0 ), {
 		plugins: [
-			Clipboard, Enter, Typing, Paragraph, Image, ImageUpload, CloudServices,
+			Clipboard, Enter, Typing, Paragraph, Image, ImageUpload, CloudServices, CloudServicesUploadAdapter,
 			BoldEditing, ItalicEditing, UnderlineEditing, HeadingEditing, UndoEditing
 		],
 		cloudServices: CS_CONFIG

This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0cfecd4. Configure here.

Copy link
Copy Markdown
Member

@Mati365 Mati365 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. Is CloudServices still needed in these samples? 🤔

Copy link
Copy Markdown
Contributor

@pszczesniak pszczesniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When im trying to upload an image from my computer i get this warning (examples editors like Balloon or Ballon Block):

Image

I think that while we removed the EasyImage, we should replace it with other solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants