Conversation
gorzelinski
reviewed
Apr 8, 2026
Contributor
gorzelinski
left a comment
gorzelinski
left a comment
There was a problem hiding this comment.
I added some comments regarding tests.
Contributor
There was a problem hiding this comment.
Don't we want to add unit tests for this adapter? Something that would be focused on the adapter behavior, like ests/EditorWatchdogAdapter.test.tsx.
Contributor
There was a problem hiding this comment.
Maybe we could add a describe block with API signature tests, like:
- v48 path (
elementConfigAttachment: true) - legacy path (
elementConfigAttachment: false)
Contributor
There was a problem hiding this comment.
https://github.com/ckeditor/ckeditor5-react/pull/663/changes#r3049668330
Maybe we could add a similar test block here:
editor.create(config)whenelementConfigAttachmentis enabled.editor.create(initialData, config)when it is disabled.
gorzelinski
approved these changes
Apr 8, 2026
Contributor
gorzelinski
left a comment
gorzelinski
left a comment
There was a problem hiding this comment.
I clicked around, did some testing, and it looks ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Summary
Pass DOM Element in the config object instead of editor constructor in CKEditor >= 48
📌 Related issues