Remove package installation tests, to be reintroduced at citusdata/packaging#1171#390
Open
onurctirtir wants to merge 5 commits intodevelopfrom
Open
Remove package installation tests, to be reintroduced at citusdata/packaging#1171#390onurctirtir wants to merge 5 commits intodevelopfrom
onurctirtir wants to merge 5 commits intodevelopfrom
Conversation
onurctirtir
commented
Mar 16, 2026
Comment on lines
+3
to
+23
| import requests | ||
|
|
||
| from .test_citus_package import get_postgres_versions_from_matrix_file | ||
| from typing import List | ||
|
|
||
| from .common_tool_methods import ( | ||
| get_supported_postgres_release_versions, | ||
| ) | ||
|
|
||
| POSTGRES_MATRIX_FILE = "postgres-matrix.yml" | ||
| POSTGRES_MATRIX_WEB_ADDRESS = "https://raw.githubusercontent.com/citusdata/packaging/all-citus/postgres-matrix.yml" | ||
|
|
||
| def get_postgres_versions_from_matrix_file(project_version: str) -> List[str]: | ||
| r = requests.get(POSTGRES_MATRIX_WEB_ADDRESS, allow_redirects=True, timeout=60) | ||
|
|
||
| with open(POSTGRES_MATRIX_FILE, "wb") as writer: | ||
| writer.write(r.content) | ||
| pg_versions = get_supported_postgres_release_versions( | ||
| POSTGRES_MATRIX_FILE, project_version | ||
| ) | ||
|
|
||
| return pg_versions |
Member
Author
There was a problem hiding this comment.
as we're removing packaging_automation/test_citus_package.py, copying the dependencies here
onurctirtir
force-pushed
the
remove-package-installation-tests
branch
from
0033db3 to
31be5ae
Compare
Member
Author
|
Unit test error is also happening on main, e.g., https://github.com/citusdata/tools/actions/runs/22571691699/job/65380877345. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See citusdata/packaging#1171.