Fix out of range panics in DateTime getters and setters#1317
Merged
pitdicker merged 6 commits intoSep 27, 2023
Conversation
Codecov Report
@@ Coverage Diff @@
## 0.4.x #1317 +/- ##
==========================================
+ Coverage 91.25% 91.50% +0.25%
==========================================
Files 38 38
Lines 17164 17310 +146
==========================================
+ Hits 15663 15840 +177
+ Misses 1501 1470 -31
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Collaborator
Author
|
This does not yet fix the |
bdc574a to
90e2607
Compare
This fixes out-of-range panics in all the `with_*` methods that use `map_local`.
90e2607 to
e002ce9
Compare
djc
approved these changes
Sep 27, 2023
This was referenced Jan 24, 2024
This was referenced Jan 24, 2024
This was referenced Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #1048.
This PR only fixes the first group of methods: those that panic on an intermediate value, but should be able to return a meaningful result. This includes formatting, and getters and setters of the
DatelikeandTimeliketraits.I made
MIN_YEARandMAX_YEAR1 year smaller to have some buffer space.DateTime::overflowing_naive_localandNaiveDateTime::overflowing_add_offsetare added to create a value in that buffer space.The rest of the PR consists of just using these methods and adding tests.