Merged
Conversation
This was referenced Dec 18, 2025
Contributor
Author
|
@kgugala @tmichalak @hcallahan-lowrisc If you have time, I would appreciate it if you could have a look at this PR and the ones building on it. |
Contributor
Author
|
@mcockrell-google @kgugala @tmichalak, sorry for pinging you again. I am not sure whether you are the maintainers of this repo, but I noticed that you were most active here lately. Would you be interested in having the Zcb and Zcmp extensions added upstream? If so, I'd appreciate your review on this and the following PRs whenever you have a moment: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small PR cleaning up some of the compressed instructions that potentially have
rs1==rd. Previously, in this case,rdwas unset and whenever we randomized instructions, special care was taken to not havers1within thereserved_rdregisters. This simplifies this logic a bit by simply constrainingrs1==rd.Furthermore, it introduces a
update_excluded_instrfunction that can be used to determine which instructions cannot be inserted with the given reserved registers. This function can be reused across test classes.This cleanup is useful to simplify implementing the Zcb #1025 and Zcmp #1026 extensions that we use in Ibex's verification.