[svsim] Expose full debug visibility in VCS waves#5232
Closed
jackkoenig wants to merge 1 commit intomainfrom
Closed
[svsim] Expose full debug visibility in VCS waves#5232jackkoenig wants to merge 1 commit intomainfrom
jackkoenig wants to merge 1 commit intomainfrom
Conversation
seldridge
reviewed
Mar 16, 2026
Comment on lines
+68
to
+70
| if (enableVpd || fsdbEnabled) { | ||
| if (fullDebugVisibility) Seq("-debug_access+all") else Seq("-debug_access+pp+dmptf") | ||
| } else Seq(), |
Member
There was a problem hiding this comment.
There's a hidden requirement that fullDebugVisibility should not be true if both enableVcd and enableVpd are false. Maybe add a require check for this?
Comment on lines
+60
to
+61
| @unroll | ||
| fullDebugVisibility: Boolean = false |
Member
There was a problem hiding this comment.
I tend towards making these directly mirror the available VCS options nearly exactly. A better approach may be to do something like how coverage works. See: https://github.com/chipsalliance/chisel/blob/main/svsim/src/main/scala/vcs/Backend.scala#L136
I can give you a table with all the options if you want to go ham with this and just add everything once and we can be done with it forever.
Contributor
Author
|
Closing in favor of #5234 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Expose
-debug_access+allfor VCS via newTraceSettings.fullDebugVisibilityReviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash)and clean up the commit message.Create a merge commit.