Skip to content

[svsim] Expose full debug visibility in VCS waves#5232

Closed
jackkoenig wants to merge 1 commit intomainfrom
jackkoenig/vcs-debug_access+all
Closed

[svsim] Expose full debug visibility in VCS waves#5232
jackkoenig wants to merge 1 commit intomainfrom
jackkoenig/vcs-debug_access+all

Conversation

@jackkoenig
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash

Release Notes

Expose -debug_access+all for VCS via new TraceSettings.fullDebugVisibility

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig requested a review from seldridge March 16, 2026 22:37
@jackkoenig jackkoenig added the Feature New feature, will be included in release notes label Mar 16, 2026
Comment on lines +68 to +70
if (enableVpd || fsdbEnabled) {
if (fullDebugVisibility) Seq("-debug_access+all") else Seq("-debug_access+pp+dmptf")
} else Seq(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a hidden requirement that fullDebugVisibility should not be true if both enableVcd and enableVpd are false. Maybe add a require check for this?

Comment on lines +60 to +61
@unroll
fullDebugVisibility: Boolean = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend towards making these directly mirror the available VCS options nearly exactly. A better approach may be to do something like how coverage works. See: https://github.com/chipsalliance/chisel/blob/main/svsim/src/main/scala/vcs/Backend.scala#L136

I can give you a table with all the options if you want to go ham with this and just add everything once and we can be done with it forever.

@jackkoenig
Copy link
Contributor Author

Closing in favor of #5234

@jackkoenig jackkoenig closed this Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New feature, will be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants