Fix SInt literals to reject too small of widths (backport #4786)#4788
Closed
Fix SInt literals to reject too small of widths (backport #4786)#4788
Conversation
Co-authored-by: Schuyler Eldridge <schuyler.eldridge@sifive.com> (cherry picked from commit db93161) # Conflicts: # src/test/scala/chiselTests/SIntOps.scala
Contributor
|
Cherry-pick of db93161 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
14 tasks
Contributor
|
Actually I don't want this backported. While it is technically a bug, there is code relying on this behavior that currently works a la ucb-bar/fixedpoint#11 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by @tymcauley ucb-bar/fixedpoint#11 (comment)
This bug was introduced 2 years ago when we added support for zero-width literals: #2932
The problem is that
BigInt.bitlengthexcludes the sign bit, so we need to add 1 to it for SInts (which is what we originally did), BUT we need special case support for zero-width SInts (only when specified).Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
For users attempting to reinterpret raw 2s complement values as SInts, use
.U.asSInt.Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash)and clean up the commit message.Create a merge commit.This is an automatic backport of pull request #4786 done by [Mergify](https://mergify.com).