Skip to content

Remove GitHub Pages deployment#35

Merged
jamestelfer merged 1 commit intomainfrom
no-more-pages
Mar 28, 2026
Merged

Remove GitHub Pages deployment#35
jamestelfer merged 1 commit intomainfrom
no-more-pages

Conversation

@jamestelfer
Copy link
Copy Markdown
Contributor

@jamestelfer jamestelfer commented Mar 28, 2026

Purpose

Completes the migration to Cloudflare Pages as the sole hosting platform. Previous PRs (#32, #33, #34) added Cloudflare deployment, restructured the build pipeline for dual deployment, and switched the canonical URL to docs.chinmina.dev. With Cloudflare live and redirects confirmed working, the GitHub Pages deployment is now redundant.

Context

Summary by CodeRabbit

  • Chores
    • Simplified deployment workflow to exclusively use Cloudflare Pages, removing GitHub Pages-specific configuration and deployment steps.

Cloudflare Pages is now the sole deployment target, with redirects
confirmed working. Remove the GitHub Pages deploy job and associated
pages artifact upload.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 28, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

The GitHub Actions deployment workflow is simplified by removing GitHub Pages deployment infrastructure, including the pages: write permission, GitHub Pages artifact upload, and the dedicated deployment job. The Cloudflare Pages deployment job remains operational.

Changes

Cohort / File(s) Summary
Workflow Deployment Configuration
.github/workflows/deploy.yaml
Removed GitHub Pages-specific permissions (pages: write), deleted GitHub Pages artifact upload step (actions/upload-pages-artifact@v4), and eliminated entire deploy job that executed GitHub Pages deployment. Generic artifact upload step retained for Cloudflare Pages deployment pipeline.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Poem

🐰 With pages gone and Cloudflare stays,
The workflow hops in newer ways,
No GitHub Pages to delay,
Just artifacts in swift array—
Simpler paths for faster days! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove GitHub Pages deployment' directly and accurately summarizes the main change—the removal of GitHub Pages deployment from the workflow while retaining Cloudflare deployment.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch no-more-pages

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Branch preview

🔗 https://no-more-pages.chinmina.pages.dev (direct commit link)

@jamestelfer jamestelfer merged commit 2fb2a8d into main Mar 28, 2026
2 of 3 checks passed
@jamestelfer jamestelfer deleted the no-more-pages branch March 28, 2026 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant