Skip to content

fix(renderer): restore tab stops if hard tabs are enabled#1677

Merged
aymanbagabas merged 1 commit intomainfrom
reset-tab-stops
Apr 13, 2026
Merged

fix(renderer): restore tab stops if hard tabs are enabled#1677
aymanbagabas merged 1 commit intomainfrom
reset-tab-stops

Conversation

@aymanbagabas
Copy link
Copy Markdown
Member

@aymanbagabas aymanbagabas commented Apr 13, 2026

When hard tabs are enabled, we optimize rendering by using actual tab characters instead of spaces. This requires us to set tab stops every 8 columns at the beginning of the rendering process.

Fixes: #1614
Supersedes: #1647

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

❌ Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.38%. Comparing base (d81b6b6) to head (7fa0685).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cursed_renderer.go 20.00% 3 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1677      +/-   ##
==========================================
- Coverage   55.72%   55.38%   -0.35%     
==========================================
  Files          25       25              
  Lines        1301     1309       +8     
==========================================
  Hits          725      725              
- Misses        490      493       +3     
- Partials       86       91       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

When hard tabs are enabled, we optimize rendering by using actual tab
characters instead of spaces. This requires us to set tab stops every 8
columns at the beginning of the rendering process.

Fixes: #1614
@aymanbagabas aymanbagabas merged commit ac355fe into main Apr 13, 2026
40 checks passed
@aymanbagabas aymanbagabas deleted the reset-tab-stops branch April 13, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v2] Hard-tab cursor optimization silently breaks column alignment in View() output

1 participant