fix(renderer): restore tab stops if hard tabs are enabled#1677
Merged
aymanbagabas merged 1 commit intomainfrom Apr 13, 2026
Merged
fix(renderer): restore tab stops if hard tabs are enabled#1677aymanbagabas merged 1 commit intomainfrom
aymanbagabas merged 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1677 +/- ##
==========================================
- Coverage 55.72% 55.38% -0.35%
==========================================
Files 25 25
Lines 1301 1309 +8
==========================================
Hits 725 725
- Misses 490 493 +3
- Partials 86 91 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5e422b1 to
0f8183c
Compare
When hard tabs are enabled, we optimize rendering by using actual tab characters instead of spaces. This requires us to set tab stops every 8 columns at the beginning of the rendering process. Fixes: #1614
0f8183c to
7fa0685
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When hard tabs are enabled, we optimize rendering by using actual tab characters instead of spaces. This requires us to set tab stops every 8 columns at the beginning of the rendering process.
Fixes: #1614
Supersedes: #1647