Skip to content

Fix sync stream bug in SpikeGLXConverterPipe#1373

Merged
h-mayorquin merged 4 commits intomainfrom
fix_dev_tests
May 28, 2025
Merged

Fix sync stream bug in SpikeGLXConverterPipe#1373
h-mayorquin merged 4 commits intomainfrom
fix_dev_tests

Conversation

@h-mayorquin
Copy link
Collaborator

Now that the sync stream is separated on neo we need this safeguard:

NeuralEnsemble/python-neo#1683

@h-mayorquin h-mayorquin self-assigned this May 27, 2025
@h-mayorquin h-mayorquin marked this pull request as ready for review May 28, 2025 16:10
@h-mayorquin h-mayorquin requested a review from pauladkisson May 28, 2025 18:21
Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@h-mayorquin h-mayorquin merged commit dedebaf into main May 28, 2025
21 of 32 checks passed
@h-mayorquin h-mayorquin deleted the fix_dev_tests branch May 28, 2025 19:13
@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.95%. Comparing base (6ad8695) to head (19b6b07).
⚠️ Report is 66 commits behind head on main.

Files with missing lines Patch % Lines
...terfaces/ecephys/spikeglx/spikeglxdatainterface.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1373      +/-   ##
==========================================
- Coverage   89.96%   89.95%   -0.01%     
==========================================
  Files         141      141              
  Lines        9096     9100       +4     
==========================================
+ Hits         8183     8186       +3     
- Misses        913      914       +1     
Flag Coverage Δ
unittests 89.95% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tainterfaces/ecephys/spikeglx/spikeglxconverter.py 92.10% <100.00%> (+0.43%) ⬆️
...terfaces/ecephys/spikeglx/spikeglxdatainterface.py 94.36% <50.00%> (-1.29%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants