Conversation
cmgosnell
commented
Mar 30, 2026
e-belfer
reviewed
Mar 31, 2026
Member
e-belfer
left a comment
There was a problem hiding this comment.
Question about one table that seems to be missing and one transform that returns nothing, but otherwise all looks sensible to me so far.
cmgosnell
commented
Mar 31, 2026
e-belfer
reviewed
Mar 31, 2026
| "type": "number", | ||
| "description": ( | ||
| "The composite depreciation rate within a given category. " | ||
| "This is typically expressed as a number between 0 and 100." |
Member
There was a problem hiding this comment.
Non-blocking: Would that not make it a pct?
Member
Author
There was a problem hiding this comment.
yea i almost converted the name to pct... I know this is the math-y version of this definition. I didn't because this is the colloquial name for the # which you use to depreciate assets.
cmgosnell
commented
Mar 31, 2026
dbt/models/rus12/core_rus12__yearly_depreciation_changes/schema.yml
Outdated
Show resolved
Hide resolved
e-belfer
approved these changes
Mar 31, 2026
Member
e-belfer
left a comment
There was a problem hiding this comment.
Some minor questions and notes, but the assets all generate and the validations pass for me, so nothing blocking merge!
dbt/models/rus12/core_rus12__yearly_depreciation_changes/schema.yml
Outdated
Show resolved
Hide resolved
19 tasks
…ass learn (never)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closes #4888. Closes #4887. Closes #5033. Closes #4886. Closes #4032. Closes #4880.
What problem does this address?
What did you change?
Documentation
Make sure to update relevant aspects of the documentation:
docs/data_sources/templates).src/metadata).Testing
How did you make sure this worked? How can a reviewer verify this?
To-do list
dbttests.pixi run pre-commit-runto run linters and static code analysis checks.pixi run pytest-cilocally to ensure that the merge queue will accept your PR.build-deploy-pudlGitHub Action manually and ensure that it succeeds.