Skip to content

Integrate last 4 RUS tables#5145

Merged
cmgosnell merged 15 commits intomainfrom
rus-final
Mar 31, 2026
Merged

Integrate last 4 RUS tables#5145
cmgosnell merged 15 commits intomainfrom
rus-final

Conversation

@cmgosnell
Copy link
Copy Markdown
Member

@cmgosnell cmgosnell commented Mar 30, 2026

Overview

Closes #4888. Closes #4887. Closes #5033. Closes #4886. Closes #4032. Closes #4880.

What problem does this address?

What did you change?

  • make draft schema
  • fix anything in column maps to adhere to schema
  • (get early review on draft schema)
  • build & test _core transforms
  • add missing filed descriptions
  • add to harvesting process
  • convert draft to real schema and migrate metadata
  • add dbt schemas
  • add validations

Documentation

Make sure to update relevant aspects of the documentation:

  • Update the release notes: reference the PR and related issues.
  • Update relevant Data Source jinja templates (see docs/data_sources/templates).
  • Update relevant table or source description metadata (see src/metadata).
  • Review and update any other aspects of the documentation that might be affected by this PR.

Testing

How did you make sure this worked? How can a reviewer verify this?

To-do list

  • If updating analyses or data processing functions: make sure to update row count expectations in dbt tests.
  • Run pixi run pre-commit-run to run linters and static code analysis checks.
  • Run pixi run pytest-ci locally to ensure that the merge queue will accept your PR.
  • Review the PR yourself and call out any questions or issues you have.
  • For PRs that change the PUDL outputs significantly, run the full ETL locally and then run the data validations using dbt. If you can't run the ETL locally then run the build-deploy-pudl GitHub Action manually and ensure that it succeeds.

@cmgosnell cmgosnell self-assigned this Mar 30, 2026
@cmgosnell cmgosnell added rus7 USDA Rural Utilities Services Form 7 -- Financial and Operating Report: Electric Distribution rus12 USDA Rural Utilities Services Form 12 -- Financial and Operating Report: Electric Power Supply labels Mar 30, 2026
@cmgosnell cmgosnell moved this from New to In progress in Catalyst Megaproject Mar 30, 2026
@e-belfer e-belfer self-requested a review March 31, 2026 13:06
Copy link
Copy Markdown
Member

@e-belfer e-belfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about one table that seems to be missing and one transform that returns nothing, but otherwise all looks sensible to me so far.

"type": "number",
"description": (
"The composite depreciation rate within a given category. "
"This is typically expressed as a number between 0 and 100."
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: Would that not make it a pct?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea i almost converted the name to pct... I know this is the math-y version of this definition. I didn't because this is the colloquial name for the # which you use to depreciate assets.

@cmgosnell cmgosnell marked this pull request as ready for review March 31, 2026 19:49
@e-belfer e-belfer self-requested a review March 31, 2026 19:55
Copy link
Copy Markdown
Member

@e-belfer e-belfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor questions and notes, but the assets all generate and the validations pass for me, so nothing blocking merge!

@cmgosnell cmgosnell enabled auto-merge March 31, 2026 20:46
@cmgosnell cmgosnell added this pull request to the merge queue Mar 31, 2026
@cmgosnell cmgosnell linked an issue Mar 31, 2026 that may be closed by this pull request
19 tasks
@cmgosnell cmgosnell moved this from In progress to In review in Catalyst Megaproject Mar 31, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 31, 2026
@cmgosnell cmgosnell added this pull request to the merge queue Mar 31, 2026
Merged via the queue into main with commit 03d1d22 Mar 31, 2026
15 checks passed
@cmgosnell cmgosnell deleted the rus-final branch March 31, 2026 22:57
@github-project-automation github-project-automation bot moved this from In review to Done in Catalyst Megaproject Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rus7 USDA Rural Utilities Services Form 7 -- Financial and Operating Report: Electric Distribution rus12 USDA Rural Utilities Services Form 12 -- Financial and Operating Report: Electric Power Supply

Projects

Status: Done

2 participants