Create core_eia176__yearly_liquefied_natural_gas_inventory#4764
Create core_eia176__yearly_liquefied_natural_gas_inventory#4764MeadBarrel wants to merge 2 commits intocatalyst-cooperative:mainfrom
Conversation
For more information, see https://pre-commit.ci
e-belfer
left a comment
There was a problem hiding this comment.
Happy to re-review this when you're ready, but this little table is looking close to done.
From looking at the reported values by year, it seems like lng_inventory_volume is the variable name from 2002-2010 and then lng_facility_volume is the variable name used from 2011-present. These do not overlap at all, so we should combine these two columns into one lng_facility_volume column. You could do something like:
df['lng_facility_volume'] = df['lng_facility_volume'].fillna(df['lng_inventory_volume'])
Once that's done, I think adding a facility_type categorical column with "lng_terminal" and "marine_terminal" would be a simple addition to make this table even skinnier.
| "description": "Land area in square meters.", | ||
| "unit": "square meters", | ||
| }, | ||
| "lng_inventory_volume": { |
There was a problem hiding this comment.
We add the units to the end of the column name typically, so these should wind up being lng_facility_volume_mcf, etc.
Overview
Closes #4695.
What problem does this address?
What did you change?
Documentation
Make sure to update relevant aspects of the documentation:
docs/data_sources/templates).src/metadata).Testing
How did you make sure this worked? How can a reviewer verify this?
To-do list
dbttests.make pytest-coveragelocally to ensure that the merge queue will accept your PR.build-deploy-pudlGitHub Action manually and ensure that it succeeds.