Skip to content

Create core_eia176__yearly_liquefied_natural_gas_inventory#4764

Draft
MeadBarrel wants to merge 2 commits intocatalyst-cooperative:mainfrom
MeadBarrel:iss_4695
Draft

Create core_eia176__yearly_liquefied_natural_gas_inventory#4764
MeadBarrel wants to merge 2 commits intocatalyst-cooperative:mainfrom
MeadBarrel:iss_4695

Conversation

@MeadBarrel
Copy link
Copy Markdown
Contributor

Overview

Closes #4695.

What problem does this address?

What did you change?

Documentation

Make sure to update relevant aspects of the documentation:

  • Update the release notes: reference the PR and related issues.
  • Update relevant Data Source jinja templates (see docs/data_sources/templates).
  • Update relevant table or source description metadata (see src/metadata).
  • Review and update any other aspects of the documentation that might be affected by this PR.

Testing

How did you make sure this worked? How can a reviewer verify this?

To-do list

  • If updating analyses or data processing functions: make sure to update row count expectations in dbt tests.
  • Run make pytest-coverage locally to ensure that the merge queue will accept your PR.
  • Review the PR yourself and call out any questions or issues you have.
  • For PRs that change the PUDL outputs significantly, run the full ETL locally and then run the data validations using dbt. If you can't run the ETL locally then run the build-deploy-pudl GitHub Action manually and ensure that it succeeds.

@zaneselvans zaneselvans added new-data Requests for integration of new data. eia176 Issues related to the EIA Form 176 natural gas supply and disposition dataset. labels Nov 14, 2025
@zaneselvans zaneselvans moved this from New to In progress in Catalyst Megaproject Nov 14, 2025
@e-belfer e-belfer self-requested a review November 27, 2025 15:46
Copy link
Copy Markdown
Member

@e-belfer e-belfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to re-review this when you're ready, but this little table is looking close to done.

From looking at the reported values by year, it seems like lng_inventory_volume is the variable name from 2002-2010 and then lng_facility_volume is the variable name used from 2011-present. These do not overlap at all, so we should combine these two columns into one lng_facility_volume column. You could do something like:

df['lng_facility_volume'] = df['lng_facility_volume'].fillna(df['lng_inventory_volume'])

Once that's done, I think adding a facility_type categorical column with "lng_terminal" and "marine_terminal" would be a simple addition to make this table even skinnier.

"description": "Land area in square meters.",
"unit": "square meters",
},
"lng_inventory_volume": {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We add the units to the end of the column name typically, so these should wind up being lng_facility_volume_mcf, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eia176 Issues related to the EIA Form 176 natural gas supply and disposition dataset. new-data Requests for integration of new data.

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

Create core_eia176__yearly_liquefied_natural_gas_inventory (Part 5)

3 participants