-
Notifications
You must be signed in to change notification settings - Fork 0
cartesi-machine-emulator 0.20.0 #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| class CartesiMachineGuestTools < Formula | ||
| desc "Set of tools to help the development of Cartesi Machine applications" | ||
| homepage "https://github.com/cartesi/machine-guest-tools" | ||
| VERSION = "v0.17.2".freeze | ||
| ROOTFS_IMAGE = "rootfs-tools.ext2".freeze | ||
| url "https://github.com/cartesi/machine-guest-tools/releases/download/#{VERSION}/#{ROOTFS_IMAGE}" | ||
| sha256 "675a49e3c9bada29f25d5b559707b34553b94280c03f44ccb8203c2cf453b541" | ||
| license "GPL-2.0-only" | ||
|
|
||
| def install | ||
| share.install self.class::ROOTFS_IMAGE | ||
| (etc/"cartesi/images").install_symlink share/self.class::ROOTFS_IMAGE => "rootfs.ext2" | ||
| end | ||
|
|
||
| test do | ||
| assert_path_exists etc/"cartesi/images/rootfs.ext2" | ||
| end | ||
| end |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,13 @@ | ||
| class CartesiMachine < Formula | ||
| desc "Meta package for the Cartesi Machine" | ||
| homepage "https://cartesi.io" | ||
| url "https://github.com/cartesi/machine-emulator/archive/refs/tags/v0.19.0.tar.gz" | ||
| sha256 "1a33fb7e0dd7030656ddbb214dcd2f5a569f64e906edb20f149b66b34e1e0dd3" | ||
| url "https://github.com/cartesi/machine-emulator/archive/refs/tags/v0.20.0.tar.gz" | ||
| sha256 "3746abb72d45dd2388f79fc24b048fe306db8e1f9f7e072176e51b95c4453949" | ||
| license "LGPL-3.0-only" | ||
|
|
||
| bottle do | ||
| root_url "https://ghcr.io/v2/cartesi/tap" | ||
| sha256 cellar: :any_skip_relocation, arm64_sonoma: "8edb6724dffd2ad487d61da3eaab1781f2eb96a65a71af696c812e6286b39bfa" | ||
| sha256 cellar: :any_skip_relocation, ventura: "d2c7400e88c12432cf55971ea9ae6edbaf72fa30c14ceeafd0b3f17148b6ffcb" | ||
| sha256 cellar: :any_skip_relocation, x86_64_linux: "b3da1acd61897dfd758e257c433140d5e8f53260beec15cb1b21933f90d41e48" | ||
| end | ||
|
|
||
| depends_on "cartesi-machine-emulator" | ||
| depends_on "cartesi-machine-guest-tools" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would name it
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What if we decide that the formula should install more things from the machine-guest-tools, like put the riscv64 guest tools somewhere so developers can use it in builds. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The name
Then that would be something like
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The main initial issue was actually the package version, which cannon go backwards. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Way back when, when we discussed what to name these packages, we had decided on cartesi-machine-emulator: the emulator binaries etc cartesi-machine-guest-tools should really only be the source for the guest package that is installed inside rootfs.ext2. It only produces a rootfs.ext2 so it can test stuff in CI, right? The fact we are using the rootfs.ext2 for other purposes is a historical mistake. We should really be getting the rootfs.ext2 from a different repo, the cartesi-machine-rootfs-image repo. Indeed, there is a tag there that we could use, currently at v0.20.0-test1 that I wanted to promote to "real life".
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I understand better the issue now. The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please use the same way Diego did on MacPorts at https://github.com/cartesi/macports-ports/blob/main/ports/emulators/cartesi-machine-rootfs-image/Portfile That is, use This is also the same way currently on linux-packages PR cartesi/linux-packages#1
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can’t do the same way he did, because brew does not allow to go to version 0.17.2. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can’t we all go back to how it was and release a proper machine-rootfs-image repo? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @edubart I already upgraded it to simply create the rootfs.ext2 from a Dockerfile. But we need to fix the guest tools package signature situation. |
||
| depends_on "cartesi-machine-linux-image" | ||
| depends_on "cartesi-machine-rootfs-image" | ||
|
|
||
| def install | ||
| # This is a metapackage | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.