Skip to content

Microservices: shared-db for java#2142

Draft
vl-leon wants to merge 35 commits intomainfrom
microservices/shared-db/java
Draft

Microservices: shared-db for java#2142
vl-leon wants to merge 35 commits intomainfrom
microservices/shared-db/java

Conversation

@vl-leon
Copy link
Copy Markdown
Contributor

@vl-leon vl-leon commented Oct 10, 2025

No description provided.

@vl-leon vl-leon requested a review from Akatuoro October 10, 2025 08:25
@renejeglinsky
Copy link
Copy Markdown
Contributor

Hi @vl-leon ,
actually we want to reduce the usage of toggles in capire. So we can't introduce more toggles in new content.
Having said that: Would it be ok if I rework your content and make a proposal how to do it w/o the toggle mechanism? If so, then @Akatuoro could wait a little with his review.

Comment thread guides/deployment/microservices.md Outdated
git submodule add https://github.com/capire/common-java
git submodule add https://github.com/capire/bookshop-java
git submodule add https://github.com/capire/data-viewer-java
git submodule update --init
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When will those be available? Asking to make sure we don't merge this PR before

@renejeglinsky
Copy link
Copy Markdown
Contributor

Does this also need to be adapted to bookstore-java and so on?
image

@vl-leon
Copy link
Copy Markdown
Contributor Author

vl-leon commented Oct 10, 2025

Does this also need to be adapted to bookstore-java and so on? image

No, no changes here up to now

@renejeglinsky renejeglinsky added the AI Review AI generated suggestions label Nov 5, 2025
github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

@vl-leon
Copy link
Copy Markdown
Contributor Author

vl-leon commented Dec 22, 2025

Does this also need to be adapted to bookstore-java and so on? image

yes, de4a3a5

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

@renejeglinsky renejeglinsky removed the AI Review AI generated suggestions label Jan 7, 2026
@renejeglinsky
Copy link
Copy Markdown
Contributor

Hi @vl-leon @Akatuoro ,
I'm sorry I polluted this PR with so many AI comments. I cleaned that up now to enable you to pick up the PR again. Hope that's still valid (or can be enhanced).

@vl-leon
Copy link
Copy Markdown
Contributor Author

vl-leon commented Apr 29, 2026

Hi @renejeglinsky,
The PR is not ready, there is a Todo list.

@renejeglinsky renejeglinsky marked this pull request as draft April 29, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants