Skip to content

it = it.skip breaks with mocha #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danjoa merged 2 commits into from
May 5, 2026
Merged

it = it.skip breaks with mocha #35

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f9864a
`it = it.skip`breaks with mocha
sjvans Apr 28, 2026
00a3b79
GET with body forbidden w/ FetchAPI
danjoa May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion test/protocols/hcql-adapter.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@ const cds = require('@sap/cds/lib')
const { GET, POST, DELETE, expect, axios } = cds.test(__dirname)

// Fetch API disallows GET|HEAD requests with body
if (axios.constructor.name === 'Naxios') it = it.skip
if (axios.constructor.name === 'Naxios') {
Copy link
Copy Markdown
Contributor

@chgeo chgeo Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This detection looks brittle. Could e.g. do it by checking for a native axios API.

const { it } = global
global.it = (title) => it(title)
}

const _unwrap = data => {
data = data.data ?? data
Expand Down