allow bolero tests to run on wasm32-unknown-unknown#204
Open
Ekleog wants to merge 1 commit intocamshaft:masterfrom
Open
allow bolero tests to run on wasm32-unknown-unknown#204Ekleog wants to merge 1 commit intocamshaft:masterfrom
Ekleog wants to merge 1 commit intocamshaft:masterfrom
Conversation
Contributor
Author
|
Disclaimer: I ended up not being able to actually use cargo-bolero, because there's no async executor that works well on the web except the browser's, and I looked into making I still think this can be useful for people who want to test sync code, but for my use case it's actually unfortunately not enough. |
Owner
|
I like the idea of supporting wasm. But I think we'll need tests in place so we don't accidentally regress before merging something like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows crate developers to run
bolero::check!()tests on wasm32-unknown-unknown.This is not fuzzing yet, but at least basic proptesting works there, with this PR :)
Considering the infrastructure required for testing (all the wasm-bindgen stuff), I'm not submitting a new test here; but I checked on the repo with my use case that a test that takes an
u8and matches for!= 4did fail as expected.Basing the test on target_os should also (hopefully) make bolero work for embedded development proptesting.