Closed
Conversation
In pr.yml's prepare job, yarn-install runs in skip-install-if-cache-hit mode — a pure lookup that does not materialize node_modules when all yarn caches hit. If the playwright cache then misses, `yarn playwright install --with-deps` fails with "Couldn't find the node_modules state file". Restore the node_modules cache (and fall back to a full yarn install) in the playwright action before running the install step. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Drop the trust-check job and the ready-for-e2e label check so every PR push runs the full CI + e2e pipeline without manual labeling. Repo is private and single-contributor, so the external-contributor trust gate is no longer needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Remove the workflows that published Playwright HTML reports to calcom/test-results-2 and wire @currents/playwright into both Playwright configs instead. The Currents reporter only registers when CURRENTS_RECORD_KEY is set, so local runs without the secret skip upload entirely. CURRENTS_PROJECT_ID is read from an env var to stay configurable across suites. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Welcome to Cal.diy, @ethan-pronev! Thanks for opening this pull request. A few things to keep in mind:
A maintainer will review your PR soon. Thanks for contributing! |
Contributor
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (101)
Disabled knowledge base sources:
📝 WalkthroughWalkthroughThis pull request refactors CI/CD workflows and test infrastructure. It removes GitHub Actions workflows for test report cleanup, publishing, and merging; deletes CI approval gating logic (trust-check job and ready-for-e2e label requirements) from the PR workflow; and removes artifact uploading steps from E2E test jobs. The test framework is migrated from ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist