feat(reverse_proxy): lb_retry_match now contains status field#7569
Open
seroperson wants to merge 3 commits intocaddyserver:masterfrom
Open
feat(reverse_proxy): lb_retry_match now contains status field#7569seroperson wants to merge 3 commits intocaddyserver:masterfrom
seroperson wants to merge 3 commits intocaddyserver:masterfrom
Conversation
Author
|
I've revisited this PR to make it simpler. Shortly, the only thing left is retrying based on status, which I moved to the I've removed retrying based on conditions as it messes with default behavior too much and it makes everything too complicated and unclear. I still can implement them in this PR, but feels like you should point me on how they must be defined and handled. Updated the PR's description, previous one is now hidden under "Initial version" spoiler. |
b8aaa26 to
4e31ada
Compare
mohammed90
reviewed
Mar 16, 2026
| type RetryConditionSet struct { | ||
| // Request matchers that determine if the request is safe to retry. | ||
| // If empty, any request matches. | ||
| MatchRaw caddy.ModuleMap `json:"match,omitempty" caddy:"namespace=http.matchers"` |
Member
There was a problem hiding this comment.
Asking to think out loud, shouldn't this be MatcherSet?
Author
There was a problem hiding this comment.
Not right exactly this place, as it's a JSON-serializable struct. It becomes MatcherSet later in runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6267
lb_retry_matchnow containsstatusfield for retries based on response.I had to do some weird parsing to be able to put it into
lb_retry_matchblock, but this definition inlb_retry_matchlooks so good that I could not resist. I can do any changes if necessary.Some examples of how this PR now works:
GETrequests retry on any errorGETrequests are never retried502/503responses trigger retry for any request method5xxresponse triggers retry503 POST-> retried503 PUT-> not retried503 GET-> not retriedPOSTerror,GETerror -> retriedPUTrequests retry on any error (in addition toGET)lb_retry_matchfunctionality503 POST-> retried503 GET-> not retried502for any method -> retriedPOSTerror -> retriedPUTerror -> not retriedGETerror -> retriedInitial PR version
Added a new field,
lb_retry_onwhich is responsible for retrying based on response.Available conditions:
502,503,5xx-likeempty_response- socket closed before receiving a responsetls_handshake_error- TLS negotiation failedresponse_timeout- upstream was too slow to respondother- any other unclassified errorIn
Caddyfileit looks like:If
lb_retry_onis unset, the old default behavior is preserved if retry-related options are set:2.1 GET requests - always retried
2.2 Non-GET requests - retried only if
lb_retry_matchis configured and the request matches itNow
lb_retry_onallows you to mostly override the default behavior (except of dial errors, they're always retried).Assistance Disclosure
Co-Authored with Claude Opus 4.6, mostly for tests and consulting about the codebase.