Skip to content

Fix check for header_up#7564

Open
yubiuser wants to merge 2 commits intocaddyserver:masterfrom
yubiuser:fix/hostport
Open

Fix check for header_up#7564
yubiuser wants to merge 2 commits intocaddyserver:masterfrom
yubiuser:fix/hostport

Conversation

@yubiuser
Copy link

PR #7454 changed the header from header_up Host {hostport} to header_up Host {upstream_hostport} when reverse_proxy for HTTPS.

However, the PR forgot to change a parser check to the new default. This results in logspam when users revert to the old behavior setting header_up Host {hostport}. Caddy starts to warn about unnecessary header_up being doubled - while this is not true anymore.

2026-03-12_10-07

No AI was used.

Signed-off-by: yubiuser <github@yubiuser.dev>
@CLAassistant
Copy link

CLAassistant commented Mar 12, 2026

CLA assistant check
All committers have signed the CLA.

@francislavoie
Copy link
Member

The change is not quite right, it needs to take into account that hostport is only passed for HTTPS and not HTTP.

Signed-off-by: yubiuser <github@yubiuser.dev>
@yubiuser
Copy link
Author

Thanks, you're correct. I've added a commit that checks if the commonScheme is https and only in this case performs the check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants