Open
Conversation
Signed-off-by: yubiuser <github@yubiuser.dev>
Member
|
The change is not quite right, it needs to take into account that hostport is only passed for HTTPS and not HTTP. |
Signed-off-by: yubiuser <github@yubiuser.dev>
Author
|
Thanks, you're correct. I've added a commit that checks if the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #7454 changed the header from
header_up Host {hostport}toheader_up Host {upstream_hostport}whenreverse_proxyfor HTTPS.However, the PR forgot to change a parser check to the new default. This results in logspam when users revert to the old behavior setting
header_up Host {hostport}. Caddy starts to warn about unnecessary header_up being doubled - while this is not true anymore.No AI was used.