Update dependencies part 1#38
Conversation
| serde_json = "1.0.95" | ||
| cargo_metadata = "0.18.0" | ||
| object = "0.32.0" | ||
| anyhow = "1.0.102" |
There was a problem hiding this comment.
Note that bumping these versions in Cargo.toml doesn't really do anything other than increase the minimum version of the package that cargo will consider. i.e. running cargo update to update Cargo.lock will have much the same effect. For a library crate, it's often a good idea to keep the minimum versions of crates as low as possible to give users of the library more choice of versions. Given that this is a binary crate, it doesn't matter, so it's fine if you want to bump these versions.
There was a problem hiding this comment.
Ah, that is indeed correct. As cargo update only updates Cargo.lock, this was a misunderstanding on my side.
I prefer to have up-to-date versions, but I am open for changes. This was just a proposal.
I would have planed to also update the other dependencies (which requires code changes) in a second step before trying to make changes to the code functionality to ease future migrations and potentially be able to benefit of the improvements of newer versions already.
|
All tests are passing on Rust 1.94.1 with the changes in #43. Shall I leave it as separate PRs or combine everything in one? |
|
I've added support for V0 mangling. I also fixed some clippy warnings that had accumulated over recent rust releases. #44. Hopefully those changes make it easier to get your changes in. |
XSpielinbox
force-pushed
the
update-dependencies
branch
from
4882996 to
50c1cc0
Compare
XSpielinbox
force-pushed
the
update-dependencies
branch
from
50c1cc0 to
8c1197c
Compare
|
Closing this as already merged as part of #40. |
2 participants
Partially addresses #35.
I have partially reviewed the changed dependencies, but I don't know whether the code is actually safe for most of the usages.
This PR builds on #43 , so should be merged afterwards.