Skip to content

refactor: replace USE_X11 with OS_LINUX for sharing code with Ozone#37

Open
c4rtune wants to merge 1 commit intomainfrom
pull/25522
Open

refactor: replace USE_X11 with OS_LINUX for sharing code with Ozone#37
c4rtune wants to merge 1 commit intomainfrom
pull/25522

Conversation

@c4rtune
Copy link
Copy Markdown
Owner

@c4rtune c4rtune commented May 9, 2026

Description of Change

This pull-request is a small first step in trying to bring support for Wayland to Electron. I'm planning to follow up on this with more pull-requests in an effort to upstream these Wayland patches.

However, those patches will need some adjustments in order to make them compatible with the upcoming Chromium changes (chromium#1085700) which will soon be merged into Electron (#25488). In particular, it should be taken into consideration that the USE_X11 and USE_OZONE build flags are no longer mutually exclusive.

Also, USE_X11 is going away so it might be desirable as a long term goal to remove it from Electron too and replace it with the Ozone equivalents.

With that in mind, this pull-request replaces a few instances of #if defined(USE_X11) with #if defined(OS_LINUX) where it was identified that the guarded code could be shared with Ozone.

The more meaningful changes will come in the upcoming pull-requests but I'll be waiting for these chromium changes to be pulled into Electron first (#24984, #25488).

Checklist

Release Notes

Notes: none

@MonnetalX
Copy link
Copy Markdown

🔍 PR Link Analysis

🔗 Ranked Links

#1 these Wayland patches

🔍 The linked comparison shows the upstream Wayland patches that this PR aims to incrementally adopt, specifically replacing USE_X11 with OS_LINUX to share code across X11 and Ozone builds.

#2 #25488

🔍 This pull request replaces USE_X11 with OS_LINUX to enable sharing code with Ozone, which is necessary for supporting Wayland in Electron.

#3 going away

🔍 The issue requests prebuilt Electron binaries that work with Wayland, as current Linux builds rely on X11 and GTK, making them perform poorly on embedded devices and Wayland-based systems.

#4 #24984

🔍 Replacing USE_X11 with OS_LINUX enables sharing code across X11 and Wayland backends, which is a necessary step for adding Wayland support to Electron.

#5 commit guidelines

🔍 This pull request replaces USE_X11 with OS_LINUX to enable sharing code with Ozone, which is a small first step toward supporting Wayland in Electron.

#6 https://github.com/electron/electron/blob/master/CONTRIBUTING.md

🔍 This pull request is a small first step toward bringing Wayland support to Electron by replacing USE_X11 with OS_LINUX to allow code sharing with Ozone.

#7 chromium#1085700

🔍 The USE_X11 macro is being replaced with OS_LINUX to allow code sharing between X11 and Wayland (Ozone) builds on Linux.

#8 these chromium changes

🔍 The webpage discusses Gerrit Code Review, which is relevant to the pull request's goal of sharing code across different display servers like X11 and Wayland.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants