Conversation
🔍 PR Link Analysis🔗 Ranked Links#1 these Wayland patches🔍 The linked comparison shows a series of patches that add Ozone/Wayland support to Electron by conditionally excluding X11-specific code and using Ozone equivalents for global shortcuts, menu bars, and window views. #2 going away🔍 Wayland is becoming the default display server on Ubuntu and provides better rendering performance on embedded devices compared to X11, making it important for Electron to support Wayland builds. #3 commit guidelines🔍 This pull request is a small first step in bringing Wayland support to Electron by upstreaming patches from the hedgepigdan fork. #4 https://github.com/electron/electron/blob/master/CONTRIBUTING.md🔍 This pull request is a small first step toward bringing Wayland support to Electron, following the upstream patches. #5 chromium#1085700🔍 This pull request adds temporary content to text.txt as a small first step toward supporting Wayland in Electron, building on existing Wayland patches. #6 these chromium changes🔍 This pull request introduces initial Wayland support for Electron by adding a temporary file to track progress. |
Description of Change
This pull-request is a small first step in trying to bring support for Wayland to Electron. I'm planning to follow up on this with more pull-requests in an effort to upstream these Wayland patches.
However, those patches will need some adjustments in order to make them compatible with the upcoming Chromium changes (chromium#1085700) which will soon be merged into Electron (#25488). In particular, it should be taken into consideration that the
USE_X11andUSE_OZONEbuild flags are no longer mutually exclusive.Also,
USE_X11is going away so it might be desirable as a long term goal to remove it from Electron too and replace it with the Ozone equivalents.With that in mind, this pull-request replaces a few instances of
#if defined(USE_X11)with#if defined(OS_LINUX)where it was identified that the guarded code could be shared with Ozone.The more meaningful changes will come in the upcoming pull-requests but I'll be waiting for these chromium changes to be pulled into Electron first (#24984, #25488).
Checklist
npm testpassesRelease Notes
Notes: none