Structured resolver errors#2482
Conversation
This reverts commit 0692157.
|
Happy to take a look when you feel this is ready, but I'm interpreting the draft state as "come back later" for now -- just wanted to note this |
|
Thanks @alexcrichton. No review needed just yet - I'm still cleaning up some final things and do one more self review, and I'll mark it as ready soon. |
|
@alexcrichton this is ready for a review now. I left some inline comments on the PR |
alexcrichton
requested review from
alexcrichton
and removed request for
fitzgen
| @@ -1,4 +1,4 @@ | |||
| failed to process feature gate for included world [a] in package [test:invalid@0.1.0]: feature gate cannot reference unreleased version 0.2.0 of package [test:invalid@0.1.0] (current version 0.1.0) | |||
| feature gate cannot reference unreleased version 0.2.0 of package [test:invalid@0.1.0] (current version 0.1.0) | |||
There was a problem hiding this comment.
As a follow up I think we should change the snippet to point to the bad version.
There was a problem hiding this comment.
And this error could become much nicer potentially - I find the current phrasing a bit vague.
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Everything here looks great to me, thanks again @PhoebeSzmucer! I think it's fine for anything further to be in follow-ups, so let's go ahead and land this.
2 participants
Part of #2460 (part 1 was here).
This PR replaces most of
anyhowusages in the resolver with structuredParserErrortype, which carries structured error information (with spans).