Fix stack overflow detection during ASAN build.#4642
Open
vchigrin wants to merge 1 commit intobytecodealliance:mainfrom
Open
Fix stack overflow detection during ASAN build.#4642vchigrin wants to merge 1 commit intobytecodealliance:mainfrom
vchigrin wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
vchigrin
requested review from
TianlongLiang,
loganek,
lum1n0us,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
Contributor
|
vchigrin
force-pushed
the
fix-stack-overflow-detection
branch
from
db72eea to
88d9dfe
Compare
lum1n0us
previously approved these changes
Mar 9, 2026
TianlongLiang
requested changes
Mar 9, 2026
Contributor
TianlongLiang
left a comment
TianlongLiang
left a comment
There was a problem hiding this comment.
Code LGTM, but code style CI check is failing
vchigrin
force-pushed
the
fix-stack-overflow-detection
branch
from
88d9dfe to
75896c5
Compare
See discussion in issue bytecodealliance#4638.
vchigrin
force-pushed
the
fix-stack-overflow-detection
branch
from
75896c5 to
8156c3f
Compare
Contributor
Author
|
Thank you very much, fixed style issues and rebased on more recent main branch commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion in issue #4638.