cross-platform test setup and ci without yarn#303
Open
mooncitydev wants to merge 1 commit intobyteball:masterfrom
Open
cross-platform test setup and ci without yarn#303mooncitydev wants to merge 1 commit intobyteball:masterfrom
mooncitydev wants to merge 1 commit intobyteball:masterfrom
Conversation
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
Several tests wiped and copied fixture dirs with
rm -rfandcp -r, which breaks on Windows (and any environment without Unix shell). This adds a tiny helper usingfs.rmSync/fs.cpSyncso the same setup runs on Linux, macOS, and Windows.The
npm testscript no longer shells out toyarn, so contributors only need Node and npm. CircleCI is switched tonpm install/npm testfor the same reason.GitHub Actions runs the suite on Ubuntu against Node 18 and 20 so regressions are caught on PRs and pushes to
master/main.Contribution prepared by mooncitydev.