Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies
IndexerGeneratorto enforce deterministic sorting of library modules by their qualified class names. It also adds a unit test (ModuleSortingLogicTest) to verify that the sorting logic remains consistent regardless of the input order provided by the compiler environment.Motivation and Context
The PR intends to solve the problem of determinism. Since KSP2 the module indexer is not processing the modules in deterministic order leading to unpredictable outcomes over each build, breaking the reproducibility. The problem can be circumvented temporarily by falling back to KSP1 or KAPT, but both of these processors are obsolete now, and Google recently removed KSP1 entirely. The issue was discussed in Inure #440 and Peristyle #239 and the
GlideIndexerbroke the reproducibility each time the difference is tested.So far using the fallback worked, but since Gradle 9.0 most of the older methods stopped working and forcing dependency updates now that triggers this non-determinism making it difficult to publish the app on F-Droid repos.