Fix NPE in DrawableTransformation when custom transform returns null#5654
Open
jayyaj12 wants to merge 6 commits intobumptech:masterfrom
Open
Fix NPE in DrawableTransformation when custom transform returns null#5654jayyaj12 wants to merge 6 commits intobumptech:masterfrom
jayyaj12 wants to merge 6 commits intobumptech:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…mation' into fix/issue-5651-drawable-transformation
…mation' into fix/issue-5651-drawable-transformation
…mation' into fix/issue-5651-drawable-transformation
Author
|
Branch updated and all checks passing. Ready for review when you have time. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR inverts the equality check in
DrawableTransformation'stransformmethod.Instead of calling
.equals()on the potentially nulltransformedBitmapResource, it now calls it onbitmapResourceToTransform, which is guaranteed to be non-null by the preceding null check.Motivation and Context
If a custom
Transformationimplementation returnsnull, the current implementation throws aNullPointerExceptionwhen attempting to check for equality.By swapping the order of comparison to
original.equals(transformed), we prevent this crash. This change also aligns the behavior withBitmapTransformation.Fixes #5651