Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
timostamm
reviewed
Mar 31, 2026
Member
timostamm
left a comment
There was a problem hiding this comment.
This is great, thank you.
Can you also add a section about the CEL environment? It's important that any CEL expression in validate.proto honors the environment provided by Protovalidate. On top of CEL's standard functions, we add:
- The strings extension, most comprehensively documented here.
- The variables
now,this,rule, andrules. - The
double,int,string, andlistfunctions, andbytesoverloads forcontains,endsWith, andstartsWith.
The variables and functions are documented on protovalidate.com.
Rules in validate.proto cannot use other functions and variables. The tool ensures that by defining the function and variable signatures in tools/internal/protovalidate-check/cel.go. A contribution that adds a new signature must add it to this definition.
Co-authored-by: Timo Stamm <ts@timostamm.de>
timostamm
reviewed
Mar 31, 2026
timostamm
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new section to CONTRIBUTING.md explaining the structural invariants of validate.proto that contributors, maintainers, and implementers must uphold.
The contributing guide now documents what the checker verifies: field-to-rules type mapping, field name consistency, extension ranges, example fields, and CEL rule requirements.