Skip to content

Raise a CompilationError for unknown rules #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timostamm merged 2 commits into from
Mar 23, 2026
Merged

Raise a CompilationError for unknown rules #445

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f152180
Raise a CompilationError for unknown rules
timostamm Mar 23, 2026
1e48ce9
uv run -- ruff check --fix protovalidate test
timostamm Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion protovalidate/internal/rules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

import celpy
from celpy import celtypes
from google.protobuf import any_pb2, descriptor, duration_pb2, message, message_factory, timestamp_pb2
from google.protobuf import any_pb2, descriptor, duration_pb2, message, message_factory, timestamp_pb2, unknown_fields # type: ignore[attr-defined]
Copy link
Copy Markdown
Member Author

@timostamm timostamm Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see, this API (google.protobuf.unknown_fields) was added in 4.21.0.
There are no stubs in types-protobuf though.

Copy link
Copy Markdown
Member

@stefanvanburen stefanvanburen Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately doesn't look like it's registered upstream either: https://github.com/search?q=repo%3Apython%2Ftypeshed%20unknown_fields&type=code. Upstream impl: https://github.com/protocolbuffers/protobuf/blob/main/python/google/protobuf/unknown_fields.py.


from buf.validate import validate_pb2
from protovalidate.internal.cel_field_presence import InterpretedRunner, in_has
Expand Down Expand Up @@ -565,6 +565,9 @@ def __init__(
self._required = field_level.required
if type_case is not None:
rules: message.Message = getattr(field_level, type_case)
if len(unknown_fields.UnknownFieldSet(rules)) > 0:
msg = f"unknown rules in {rules.DESCRIPTOR.full_name}"
raise CompilationError(msg)
# For each set field in the message, look for the private rule
# extension.
for list_field, _ in rules.ListFields():
Expand Down Expand Up @@ -1031,6 +1034,9 @@ def _new_scalar_field_rule(
check_field_type(field, 0, "google.protobuf.Any")
result = AnyRules(self._env, self._funcs, field, field_level)
return result
else:
msg = f"unknown rule type {type_case!r}"
raise CompilationError(msg)

def _new_field_rule(
self,
Expand Down
Loading