Test registry-enabled plugins depend on registry-enabled plugins#2368
Merged
stefanvanburen merged 3 commits intomainfrom Mar 31, 2026
Merged
Test registry-enabled plugins depend on registry-enabled plugins#2368stefanvanburen merged 3 commits intomainfrom
stefanvanburen merged 3 commits intomainfrom
Conversation
We shouldn't add to this list, but we also aren't planning to go back to patch these particular plugin versions.
pkwarren
approved these changes
Mar 31, 2026
| case p.Registry.Cmake != nil: | ||
| return "cmake" | ||
| default: | ||
| return "" |
Member
There was a problem hiding this comment.
Should we fail if we get here (to make sure we keep this test up to date)?
Member
Author
There was a problem hiding this comment.
it's a little gnarly, but tried it with reflect: b0be09a. Wish there was a better linter for this, but I don't think exhaustruct would work here and didn't see anything else.
pkwarren
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to ensure that any plugin that ends up with registry configuration only depends on plugins that also have registry configuration (for that same registry).
This caught a few past plugins that violate that (b9abdd2), that we aren't planning to go back and update at this point, to demonstrate that the test works.