feat: add usePageCss option, add toCanvasList and toImage method for large html#473
Open
hzsrc wants to merge 21 commits intobubkoo:masterfrom
Open
feat: add usePageCss option, add toCanvasList and toImage method for large html#473hzsrc wants to merge 21 commits intobubkoo:masterfrom
hzsrc wants to merge 21 commits intobubkoo:masterfrom
Conversation
…rge amount of sub nodes
Contributor
|
👋 @hzsrc 💖 Thanks for opening this pull request! 💖 Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #473 +/- ##
==========================================
+ Coverage 62.93% 66.50% +3.57%
==========================================
Files 10 10
Lines 580 612 +32
Branches 143 150 +7
==========================================
+ Hits 365 407 +42
+ Misses 151 144 -7
+ Partials 64 61 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ed to 1px, but in <img src="svg"> it is rendered to 2px. Then height is different and the bottom 1px is lost, 10 nodes will lost 10px.
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
|
|
||
| svg.setAttribute('width', `${width}`) | ||
| svg.setAttribute('height', `${height}`) | ||
| // fix: if ratio=2 and style.border='1px', in html it is actually rendered to 1px, but in <img src="svg"> it is rendered to 2px. Then height is different and the bottom 1px is lost, 10 nodes will lost 10px. |
There was a problem hiding this comment.
This image is missing a text alternative. This is a problem for people using screen readers.
added 2 commits
August 16, 2024 19:37
…ation of canvas size, so this can export a very large htm. And use a ``getMaxCanvasHeight` method to raise the canvas size limit from 16384 to 65535(Chrome) or 32767(Firefox)
|
|
||
| svg.setAttribute('width', `${width}`) | ||
| svg.setAttribute('height', `${height}`) | ||
| // fix: if ratio=2 and style.border='1px', in html it is actually rendered to 1px, but in <img src="svg"> it is rendered to 2px. Then height is different and the bottom 1px is lost, 10 nodes will lost 10px. |
There was a problem hiding this comment.
This image is missing a text alternative. This is a problem for people using screen readers.
hzsrc
changed the title
| return urlToImg(url).then(function(img: HTMLImageElement): Promise<HTMLImageElement> | HTMLImageElement { | ||
| var ctx = get2dCtx(1, BCheckHeight) | ||
| ctx.drawImage(img, Math.floor(img.width / 2), img.height - BCheckHeight, 1, BCheckHeight, 0, 0, 1, BCheckHeight) | ||
| //win.document.write(i + '<img src="' + ctx.canvas.toDataURL() + '" style="width:10px" />'); //debug |
There was a problem hiding this comment.
This image is missing a text alternative. This is a problem for people using screen readers.
This will fix some problems that the last page of exported pdf is truncated.
`usePageCss` option is default set to 'true'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…arge amount of sub nodes
Description
Motivation and Context
Types of changes
Self Check before Merge