Skip to content

[FEAT] Add windows_latest to Github workflow matrix OS #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jared-rimmer wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[FEAT] Add windows_latest to Github workflow matrix OS #354

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e330420
Add windows_latest to Github workflow matrix OS
jared-rimmer Jun 2, 2023
9663a94
Add missing runs_on and use matrix.os
jared-rimmer Jun 2, 2023
de6d4a0
Refactor get latest release step
jared-rimmer Jun 2, 2023
84f7900
Add a checkout step before getting the release
jared-rimmer Jun 2, 2023
ace9ec4
Add run object to checkout
jared-rimmer Jun 2, 2023
b2b5c27
Remove with settings
jared-rimmer Jun 2, 2023
ad28fd5
Add fetch-depth
jared-rimmer Jun 2, 2023
4afd54a
Merge branch 'main' into feat/add-windows-os-to-github-workflows
glsdown Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/ci_test_package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ jobs:
fail-fast: false # Don't fail one DWH if the others fail
matrix:
warehouse: ["snowflake", "bigquery"]
runs-on: ubuntu-latest
os: [ubuntu-latest, windows-latest]
runs-on: ${{ matrix.os }}
environment:
name: Approve Integration Tests
permissions:
Expand Down Expand Up @@ -103,7 +104,8 @@ jobs:
warehouse: ["snowflake", "bigquery"]
# When supporting a new version, update the list here
version: ["1_3_0", "1_4_0", "1_5_0"]
runs-on: ubuntu-latest
os: [ubuntu-latest, windows-latest]
runs-on: ${{ matrix.os }}
environment:
name: Approve Integration Tests
permissions:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/main_test_package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ jobs:
matrix:
warehouse: ["snowflake", "bigquery"]
version: ["1_3_0", "1_4_0", "1_5_0"]
runs-on: ubuntu-latest
os: [ubuntu-latest, windows-latest]
runs-on: ${{ matrix.os }}
permissions:
contents: "read"
id-token: "write"
Expand Down