fix(nebius): persist firewall rules across instance stop/start cycles#106
Open
fix(nebius): persist firewall rules across instance stop/start cycles#106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After=netfilter-persistent.service) toufw.servicevia cloud-initruncmd, fixing a race condition where both services calliptables-restoreconcurrently on boot, causing UFW to fail withiptables-restore: line 4 failediptables-persistentand runsnetfilter-persistent saveto snapshot the complete iptables state (UFW chains + DOCKER-USER rules) so it survives stop/start cyclesnetfilter-persistentrestores the snapshot first, then UFW starts after it and re-applies cleanlyChanges
cloud/v1/providers/nebius/instance.go—generateCloudInitUserData()iptables-persistentto cloud-initpackageslist (installsnetfilter-persistentservice)printfpiped totee— writesAfter=netfilter-persistent.serviceto/etc/systemd/system/ufw.service.d/after-netfilter.conf, followed bysystemctl daemon-reloadsudo netfilter-persistent saveas the finalruncmdcommand to snapshot the complete iptables state to/etc/iptables/rules.v4runcmdentries: commands are now double-quoted with\and"properly escaped, preventing YAML-special characters from being misinterpreted by the cloud-init parserTest plan
host-sshhealth check passesjournalctlthat UFW starts afternetfilter-persistent(no race)sudo iptables -L DOCKER-USER -n -vshows all rules after rebootsudo ufw status verboseshows correct rules after reboot