Open
Conversation
📊 Coverage Report
|
aomarks
requested changes
Mar 17, 2026
| @@ -0,0 +1,47 @@ | |||
| /** | |||
| * @license | |||
| * Copyright 2025 Google LLC | |||
|
|
||
| override connectedCallback() { | ||
| super.connectedCallback(); | ||
| setInterval(() => { |
Member
There was a problem hiding this comment.
I know this is just a test, but the timer needs to get closed on disconnectedCallback
| "dependencies": [ | ||
| "typescript-files-and-deps" | ||
| ], | ||
| "files": [ |
Member
There was a problem hiding this comment.
This has no "output", so it can never get cached by wireit
| "output": [] | ||
| } | ||
| }, | ||
| "repository": { |
Member
There was a problem hiding this comment.
nit: more idiomatic to have the package metadata the the top
| "moduleResolution": "nodenext", | ||
| "resolveJsonModule": true, | ||
| "isolatedModules": true, | ||
| "strict": true, |
Member
There was a problem hiding this comment.
We may want to make sure we have all the same strictness checks enabled externally as internal.
| @@ -0,0 +1,20 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "target": "ES2022", | |||
Member
There was a problem hiding this comment.
Let's bump to 2024 for target and lib?
| @@ -0,0 +1,26 @@ | |||
| /** | |||
| * @license | |||
| * Copyright 2025 Google LLC | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New closure-compatible setup for integration into internal codebases