Skip to content

Add coverage threshold and migrate CI to shared workflow #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GoogilyBoogily wants to merge 4 commits into
base: main
Choose a base branch
from
+19 −33
Open

Add coverage threshold and migrate CI to shared workflow #39

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0e7c1d2
Add coverage threshold and migrate CI to shared workflow
GoogilyBoogily Apr 17, 2026
a215aae
Address review feedback: pin workflow SHA, exclude test files from co…
GoogilyBoogily Apr 17, 2026
a45ffa9
Add minimal permissions block to CI workflow
GoogilyBoogily Apr 17, 2026
94cdfeb
Fix pinned SHA to match remote HEAD
GoogilyBoogily Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: "Unit Tests"
name: "CI"

on:
push:
Expand All @@ -9,17 +9,9 @@ on:
branches:
- "*"

jobs:
build:
name: "Unit Tests on Ubuntu"
runs-on: ubuntu-latest
permissions:
contents: read

steps:
- uses: actions/checkout@v6
- name: Use Node.js
uses: actions/setup-node@v6
with:
node-version-file: .nvmrc
- run: npm ci
- run: npx eslint . --ext .js,.ts
- run: npm test
jobs:
ci:
uses: braintree/web-sdk-github-actions/.github/workflows/ci.yml@3d3621c5bb46edf879370cec4e63a34d345db4cf
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
10 changes: 10 additions & 0 deletions jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,14 @@ module.exports = {
preset: "ts-jest",
testEnvironment: "node",
testPathIgnorePatterns: ["__tests__/helpers.ts"],
collectCoverage: true,
collectCoverageFrom: ["src/**/*.ts"],
coverageThreshold: {
global: {
lines: 80,
statements: 80,
branches: 80,
functions: 80,
},
},
};
22 changes: 3 additions & 19 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading