Add coverage threshold and migrate CI to shared workflow#44
Open
GoogilyBoogily wants to merge 4 commits intomainfrom
Open
Add coverage threshold and migrate CI to shared workflow#44GoogilyBoogily wants to merge 4 commits intomainfrom
GoogilyBoogily wants to merge 4 commits intomainfrom
Conversation
- Add 80% coverageThreshold (lines/statements/branches/functions) to enforce SDLC Level 2 coverage requirements - Migrate CI workflow to shared reusable workflow from braintree/web-sdk-github-actions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR enforces a minimum Jest coverage requirement for the TypeScript sources and switches the repository’s CI to a shared reusable GitHub Actions workflow from braintree/web-sdk-github-actions.
Changes:
- Enable Jest coverage collection and add a global 80% coverage threshold.
- Update CI to call a shared reusable workflow instead of running local steps.
- Regenerate
package-lock.jsonmetadata (removingpeer: trueflags).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Adds Jest coverage collection + global 80% thresholds |
| package-lock.json | Lockfile metadata updates consistent with a re-generation |
| .github/workflows/ci.yml | Replaces in-repo CI steps with a reusable workflow call |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…verage - Pin shared CI workflow to commit SHA for supply-chain safety - Exclude src/__tests__/** from collectCoverageFrom to prevent test files from inflating coverage metrics - Enable Vitest coverage collection by default (sanitize-url) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Restrict GITHUB_TOKEN to contents:read — CI only needs to checkout code, lint, and run tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Local submodule was behind remote — used wrong commit hash. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lvandenboom
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coverageThreshold(lines/statements/branches/functions) to enforce coverage requirementsTest plan
npm testpasses locally with new coverage threshold