Fix #137: non-abstract requires components don't need explicit args#139
Open
yaswanth169 wants to merge 1 commit intoboyland:masterfrom
Open
Fix #137: non-abstract requires components don't need explicit args#139yaswanth169 wants to merge 1 commit intoboyland:masterfrom
yaswanth169 wants to merge 1 commit intoboyland:masterfrom
Conversation
Owner
Author
|
Thanks for pointing that out. I see the concern about breaking changes related to #136 and ordering. I will revisit the interaction between this change and the existing behavior to understand where the conflict arises and ensure we don’t break the expected ordering semantics. Will update once I have analyzed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Fix #137: Non-abstract components in requires don't need explicit arguments
Description:
Problem
When a module had non-abstract components (syntax, judgments, or theorems with concrete definitions) in its requires section, users were required to pass them as explicit arguments during instantiation. This was unnecessary — non-abstract components are self-contained and don't
need to be "filled in" by the caller.
For example, given a functor:
requires
abstract syntax id
abstract syntax nonid
syntax e ::= id | nonid ← non-abstract, should not need an arg
abstract judgment add: e + e = e
Users had to write:
module m = functor[id-impl, nonid-impl, e-impl, add-impl] ← e-impl was unnecessary
Fix
Only abstract components now require explicit arguments during instantiation. Non-abstract components are automatically moved into the instantiated module's body.
Changes:
Regression tests updated (modulegood05, modulegood06, test1) to remove the now-unnecessary non-abstract arguments.
New regression tests added: